search

BlackBeltPanda / Transport-Pipes

Buildcraft without mods! This is a fork of the original Transport-Pipes plugin featuring support for newer versions of Spigot, many bug fixes, performance improvements, and end-user enhancements.
https://www.spigotmc.org/resources/transport-pipes.20873/
MIT License
39 stars 10 forks source link

Transport-Pipes causes a problem. #26

Closed ErythroCraft closed 2 years ago

ErythroCraft commented 2 years ago

Hello.

Hello. I asked the Author of LWC if he can fix this bug. So, he said the plugin Transport-Pipes caused it.

Bug: [22:56:31] [Server thread/WARN]: at de.robotricker.transportpipes.utils.LWCUtils.onPostRegistration(LWCUtils.java:40)

Please reade the full post here on lwc.

Maybe you can fix this bug on 1.19

ErythroCraft commented 2 years ago

So a change in that plugin would be required (null check for the block, or check for isEntity() on the protection)

ErythroCraft commented 2 years ago

using LWC 5.0.16 from Jenkins

BlackBeltPanda commented 2 years ago

Can you post the full stacktrace? The link you posted above goes nowhere.

ErythroCraft commented 2 years ago

[22:56:31] [Server thread/WARN]: com.griefcraft.scripting.ModuleException: LWC Module threw an uncaught exception! LWC version: 5.0.16 [22:56:31] [Server thread/WARN]: at com.griefcraft.scripting.ModuleLoader.dispatchEvent(ModuleLoader.java:351) [22:56:31] [Server thread/WARN]: at com.griefcraft.listeners.LWCEntityListener.entityCreatedByPlayer(LWCEntityListener.java:182) [22:56:31] [Server thread/WARN]: at com.griefcraft.listeners.LWCEntityListener.onHangingPlace(LWCEntityListener.java:91) [22:56:31] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [22:56:31] [Server thread/WARN]: at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) [22:56:31] [Server thread/WARN]: at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [22:56:31] [Server thread/WARN]: at java.base/java.lang.reflect.Method.invoke(Method.java:568) [22:56:31] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) [22:56:31] [Server thread/WARN]: at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) [22:56:31] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:589) [22:56:31] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:576) [22:56:31] [Server thread/WARN]: at net.minecraft.world.item.ItemHanging.a(ItemHanging.java:72) [22:56:31] [Server thread/WARN]: at net.minecraft.world.item.ItemStack.useOn(ItemStack.java:279) [22:56:31] [Server thread/WARN]: at net.minecraft.server.level.PlayerInteractManager.a(PlayerInteractManager.java:552) [22:56:31] [Server thread/WARN]: at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1547) [22:56:31] [Server thread/WARN]: at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:33) [22:56:31] [Server thread/WARN]: at net.minecraft.network.protocol.game.PacketPlayInUseItem.a(PacketPlayInUseItem.java:1) [22:56:31] [Server thread/WARN]: at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31) [22:56:31] [Server thread/WARN]: at net.minecraft.server.TickTask.run(SourceFile:18) [22:56:31] [Server thread/WARN]: at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:157) [22:56:31] [Server thread/WARN]: at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1190) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1) [22:56:31] [Server thread/WARN]: at net.minecraft.util.thread.IAsyncTaskHandler.y(SourceFile:131) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.be(MinecraftServer.java:1169) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1162) [22:56:31] [Server thread/WARN]: at net.minecraft.util.thread.IAsyncTaskHandler.bo(SourceFile:116) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1145) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1051) [22:56:31] [Server thread/WARN]: at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) [22:56:31] [Server thread/WARN]: at java.base/java.lang.Thread.run(Thread.java:833) [22:56:31] [Server thread/WARN]: Caused by: java.lang.NullPointerException: Cannot invoke "org.bukkit.block.Block.getLocation()" because the return value of "com.griefcraft.model.Protection.getBlock()" is null

[22:56:31] [Server thread/WARN]: at de.robotricker.transportpipes.utils.LWCUtils.onPostRegistration(LWCUtils.java:40)

[22:56:31] [Server thread/WARN]: at com.griefcraft.scripting.ModuleLoader.dispatchEvent(ModuleLoader.java:343) [22:56:31] [Server thread/WARN]: ... 30 more

BlackBeltPanda commented 2 years ago

What version of TransportPipes are you using?

ErythroCraft commented 2 years ago

Transport-Pipes: v5.4.0-bCUSTOM ProtocolLib: 4.8.0

ErythroCraft commented 2 years ago

I testest LWCX - It's better working and I can use Transport-Pipes correctly.

Maybe you can hook into LWCX.

BlackBeltPanda commented 2 years ago

Can you try with this version and let me know if you still have the same issue? https://cdn.discordapp.com/attachments/315610036204470272/954878530016141372/TransportPipes-5.4.1-SNAPSHOT.jar

ErythroCraft commented 2 years ago

[21:53:41] [Server thread/ERROR]: Error occurred while enabling Bookshelf v3.0.8.0 (Is it up to date?) java.lang.NoClassDefFoundError: com/griefcraft/scripting/event/LWCEntityInteractEvent at java.lang.Class.getDeclaredMethods0(Native Method) ~[?:?] at java.lang.Class.privateGetDeclaredMethods(Class.java:3402) ~[?:?] at java.lang.Class.getDeclaredMethods(Class.java:2504) ~[?:?] at com.griefcraft.scripting.ModuleLoader.doesObjectOverrideMethod(ModuleLoader.java:299) ~[?:?] at com.griefcraft.scripting.ModuleLoader.registerFastCache(ModuleLoader.java:218) ~[?:?] at com.griefcraft.scripting.ModuleLoader.registerModule(ModuleLoader.java:460) ~[?:?] at com.loohp.bookshelf.listeners.hooks.LWCEvents.hookLWC(LWCEvents.java:54) ~[?:?] at com.loohp.bookshelf.Bookshelf.onEnable(Bookshelf.java:295) ~[?:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:342) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:480) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_18_R2.CraftServer.enablePlugin(CraftServer.java:518) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at org.bukkit.craftbukkit.v1_18_R2.CraftServer.enablePlugins(CraftServer.java:432) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:612) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:414) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:263) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1007) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.18.2-R0.1-SNAPSHOT.jar:3493-Spigot-b081915-9d46b56] at java.lang.Thread.run(Thread.java:833) [?:?] Caused by: java.lang.ClassNotFoundException: com.griefcraft.scripting.event.LWCEntityInteractEvent at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:147) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:99) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] ... 19 more

ErythroCraft commented 2 years ago

java.lang.NoClassDefFoundError: com/griefcraft/scripting/event/LWCEntityInteractEvent

BlackBeltPanda commented 2 years ago

[21:53:41] [Server thread/ERROR]: Error occurred while enabling Bookshelf v3.0.8.0 (Is it up to date?) Caused by: java.lang.ClassNotFoundException: com.griefcraft.scripting.event.LWCEntityInteractEvent at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:147) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:99) ~[spigot-api-1.18.2-R0.1-SNAPSHOT.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?] ... 19 more

That's not a TransportPipes error. Looks like a compatibility error with Bookshelf and LWC.

I think your bug is fixed?

TransportPipes 5.4.1 has some major updates made to support pretty much any protection plugin, so it should work better. =)

ErythroCraft commented 2 years ago

Ok. Than the update you created fixed 11 issues.

now 19 more by other plugins.

Thank you very much.

BlackBeltPanda commented 2 years ago

Happy to help. =)

ErythroCraft commented 2 years ago

LWC created a pull to fix.

https://github.com/BlackBeltPanda/Transport-Pipes/pull/27