BlackDemonZyT / BotSentry

Official repository for Bot-Sentry issues, information, etc..
6 stars 0 forks source link

BotSentry incompatibility with LimboAPI #125

Open pVICTORIAAAA opened 4 months ago

pVICTORIAAAA commented 4 months ago

Velocity plugin incompatibility with LimboAPI & BotSentry (Yeah for bug you need plugin that uses LimboAPI for example LimboAUTH cuz its verification plugin)

So yeah basically plugins works perfectly until you take a look at botsentry what it does;

So yeah, starting with no errors console shows perfectly that everything works even under /velocity plugins velocity ver is 3.3.0 - snapshot | LimboAPI is 1.1.24

Reproduction of the issue is kinda easy; you just need to start Velocity server with plugins LimboAPI + LimboAUTH for example and BotSentry, it shows that it run perfectly but it for sure don't tested with public proxies which it detected, even I blacklisted myself but yeah, still I could join without hesitation. Hope it get Fixed ASAP.

image

! CONFIG FILE FOR BOTSENTRY IS CLEARED EVERY SCREENSHOT ! That's how it should look like and it is great until u use one of plugin that uses library which is limboapi + limboauth for example image

And with limboauth, there's no display for that kick message anymore image

Laurenshup commented 4 months ago

Okay, to be sure. Players are not being kicked when you have LimboAPI and LimboAuth active. Could you maybe send me a screenshot of /bs scan of a player using a VPN/proxy? I want to check if it actually adds it to the blacklist or not.

pVICTORIAAAA commented 4 months ago

image Here you go

Okay Thats fucking weird, I opened the blacklist.json

image

Tried add by command but still can even join image

okay nvm it added after restart but it doesn't flag me :v image

yeah no kick F image

Laurenshup commented 4 months ago

Okay thanks, looks like internally BotSentry does correctly flag it as disconnected. I am not sure what LimboAPI and LimboAuth are actually about, as it looks like it changes the functions of Velocity that disconnects the player. Do both plugins cooperate together, are both needed to let this happen?

pVICTORIAAAA commented 4 months ago

Yes, limboapi is created and maintained by same developer and they are open source on GitHub also they are needed to be together to botsentry stop working correctly.

As provided information before ur latest response u got screenshot with botsentry kick which was tested with only limboapi and botsentry but it works fine, hope it helps you wish u best, goodnight!

pVICTORIAAAA commented 4 months ago

This link is to author of limboapi and limboauth you could view source of their plugin here: https://github.com/Elytrium/LimboAuth https://github.com/Elytrium/LimboAPI https://github.com/Elytrium

Laurenshup commented 4 months ago

Okay, so I am going to simulate LimboAuth and LimboAPI on my testing server, do you have any special settings I should test with?

pVICTORIAAAA commented 4 months ago

Okay, so I am going to simulate LimboAuth and LimboAPI on my testing server, do you have any special settings I should test with?

No, just run it default settings you can change anything u want doesn't work any option for me