BlackFoundryCom / robo-cjk

RoboFont extension for CJK font development
GNU General Public License v3.0
15 stars 5 forks source link

add designspace.json #10

Closed BlackFoundry closed 3 years ago

BlackFoundry commented 3 years ago

add the file accodring to the "font infos" to the project on the repo so that one can generate the VarC VF font

fabiocaccamo commented 3 years ago

@BlackFoundry @GaetanBaehr do you mean the possibility to manage it via API like fontLib.json?

BlackFoundry commented 3 years ago

Please refer to this, the designspace.json is required to build the binary font: https://github.com/BlackFoundryCom/rcjk-tools#robocjk-to-varc-vf-workflow

fabiocaccamo commented 3 years ago

@BlackFoundry this is not strictly-related to how API works, actually the designspace.json is automatically pushed but not managed by the APIs, if it must be managed with some automatism I should know the desired result.

justvanrossum commented 3 years ago

Can this please be resolved? I'm not sure I understand what needs to be done to make it happen.

(Gaëtan imported a new version of the hangul.rcjk project, which did contain a designspace.json file, but designspace.json didn't get imported and now no longer exists in git, making the CI fail. Or something like that.)

fabiocaccamo commented 3 years ago

This will be solved soon, in the meantime to avoid the CI failure the designspace.json file could be added manually to the repository.

fabiocaccamo commented 3 years ago

@justvanrossum @GaetanBaehr @BlackFoundry this is done.

Now designspace.json is imported when importing a font from the backend and exported to git when modified. It is possible to modify designspace.json data using the API (the local client must be updated with the latest client version).


I'm sorry, I committed a mistake and referenced the wrong repo in the commit (I did it just for demonstrating that referencing issues cross-repositories could be confusing :) ).

I reference the commit manually here: Added designspace support to API and client.

justvanrossum commented 3 years ago

All existing designspace.json files have now been replaced with empty ones. Please revert to what they were before.

fabiocaccamo commented 3 years ago

Were there any other designspace.json files besides this: https://github.com/BlackFoundryCom/gs-cjk-rcjk/commit/923dfed9edb611a22c02a4b09ede448307338fdf ?

justvanrossum commented 3 years ago

Were there any other designspace.json files besides this: BlackFoundryCom/gs-cjk-rcjk@923dfed ?

They were non-empty in every .rcjk project, but they were (most likely) all identical to that one.

fabiocaccamo commented 3 years ago

There is no need to revert changes, just need to update the font designspace.json data from the backend or via the API and it will be pushed on the next commit.

justvanrossum commented 3 years ago

Whatever you call it, please make it happen... I'm not working with the front end, and don't even have access to the projects from that side.

fabiocaccamo commented 3 years ago

I added them, so in the next sync designspaces will be pushed.

justvanrossum commented 3 years ago

Thanks! This issue should be closed (but I can't).

fabiocaccamo commented 3 years ago

Me neither, @BlackFoundry could you close this issue?