search

BlackFoundryCom / robo-cjk

RoboFont extension for CJK font development
GNU General Public License v3.0
15 stars 5 forks source link

SQL commit message *should* include the username resposible of the last change #15

Closed BlackFoundry closed 3 years ago

justvanrossum commented 3 years ago

Or: all user names since the last commit, if there were more.

BlackFoundry commented 3 years ago

Just said: GIT should be the main data storage; SQL being a speedy caching frontend. The idea is that we don't loose the benefits of GIT

fabiocaccamo commented 3 years ago

This can be done (it will surely slowdown the push phase a little bit).

fabiocaccamo commented 3 years ago

Is it ok a message like Updated by: Jeremie Hornus, Gaetan Baher, etc... ?

justvanrossum commented 3 years ago

This appears to be implemented, but I can't close the issue.

(Best to reference the issue when committing changes relating to the issue.)

fabiocaccamo commented 3 years ago

@justvanrossum yes this has been implemented.

Unfortunately the issue has been opened on the wrong repo, so it was not possible for me to reference the issue in the commit.

To avoid this problem in future the next issues related to backend/api should be opened on the django-robo-cjk repository.

justvanrossum commented 3 years ago

You can reference other repos, too: BlackFoundryCom/django-robo-cjk#1

fabiocaccamo commented 3 years ago

Cool! I didn't know that, thank you very much for the tip!