Glyphs never get reloaded once opened

BlackFoundryCom / robo-cjk

RoboFont extension for CJK font development

GNU General Public License v3.0

15 stars 5 forks source link

Glyphs never get reloaded once opened #29

Closed justvanrossum closed 1 year ago

justvanrossum commented 1 year ago

If you open a glyph editor in RoboCJK, then close it, it will never reload the glyph from the server, so any change made by someone else will not be seen.

Scenario:

User A opens glyph G
User A closes glyph G
User B opens glyph G
User B edits glyph G
User B closes glyph G
User A opens glyph G
User A doesn't see B's changes
User A closes glyph G
User B's changes are now lost

justvanrossum commented 1 year ago

The source of the problem is here:

https://github.com/BlackFoundryCom/robo-cjk/blob/c4bfb536d5830f9f4ac3073cf3945d284b0b1b1b/sources/models/font.py#L284-L294

The used cache is never cleared.

justvanrossum commented 1 year ago

This got resolved but not in a PR, so it's hard to reference :(