Neural mode selection for SchwarzschildEccentric

BlackHolePerturbationToolkit / FastEMRIWaveforms

Blazingly fast EMRI waveforms

GNU General Public License v3.0

38 stars 26 forks source link

Neural mode selection for SchwarzschildEccentric #84

Closed CChapmanbird closed 6 months ago

CChapmanbird commented 8 months ago

Initial functionality for neural mode selection, for Schwarzschild Eccentric waveforms with Bicubic Spline amplitudes:

New NeuralModeSelector class for handling neural network mode predictors
New FSEFBicubic waveform that supports choosing mode selector class: supports mode prediction
Some bug fixes.

Note that the files required for running the neural mode selector are not included. For now they can be requested. This will be addressed in the near future.

mikekatz04 commented 6 months ago

@CChapmanbird Is this ready for production use?

CChapmanbird commented 6 months ago

I will suggest that we close this for now and implement it with the Kerr Equatorial Eccentric branch when that is ready:

This pull request is now obsolete with respect to that code
The neural mode selection functionality will not be available to general users until that point

Feel free to re-open if you disagree.