search

BlackHolePerturbationToolkit / Teukolsky

A Mathematica package for computing solutions to the Teukolsky equation.
http://bhptoolkit.org/Teukolsky/
MIT License
21 stars 3 forks source link

Error when KerrGeoOrbit uses the Darwin parametrization #42

Closed nielsw2 closed 1 year ago

nielsw2 commented 1 year ago

If the KerrGeoOrbit[] function is called with the option Parametriation->"Darwin" the TrajectoryDeltas are not computed and so the following code produces lots of error.

orbit = KerrGeoOrbit[0, 10, 0.2`50, 1, Parametrization -> "Darwin"];
mode = TeukolskyPointParticleMode[-2, 2, 2, 3, 0, orbit];

As I think the source integration assumes Mino time parametrization we should get the TeukolskyPointParticleMode[] function to check the parametrization and return an error if it is not Mino.

znasipak commented 1 year ago

I think returning an error is a good intermediate solution. Long term, it should be straightforward to also output the TrajectoryDeltas for Darwin parameters and setup the source integration to handle this parametrization as well. It should be just an afternoon's worth of work. I just need to find the time.

nielsw2 commented 1 year ago

Ok. Let's return an error for now and if we have time we can add in the case for Darwin. It's not top priority as the Mino time version works just fine. Maybe we can leave implementing it until someone specifically requests it.