search

BlackHolePerturbationToolkit / Teukolsky

A Mathematica package for computing solutions to the Teukolsky equation.
http://bhptoolkit.org/Teukolsky/
MIT License
21 stars 3 forks source link

Rewrite interface #8

Closed barrywardell closed 4 years ago

barrywardell commented 4 years ago

This series of commits mimics those that were done for the ReggeWheeler package pull request 1 and pull request 2. It is a rewrite of the interface part of the package, to simplify things and make the option handling more robust. It also removes support for having multiple homogeneous solutions inside a single TeukolskyRadialFunction as it over-complicated things with little gain.

nielsw2 commented 4 years ago

Only noticed one small issue. When computing the TeukolskyRadial function if the precision of omega is great than the precision of 'a' then a warning is given about the precision of 'a' being less than the WorkingPrecision.

Is is possible to set the WorkingPrecision to be Min[omega,a]?

barrywardell commented 4 years ago

The precision problem has now been fixed in 0379823. Ok to merge pull request?

nielsw2 commented 4 years ago

Just checked and it all looks good. Merge away.