BlackJar72 / ClimaticBiomePlacement

An landmass generator and biome provider for Minecraft
https://minecraft.curseforge.com/projects/climatic-biome-placement?gameCategorySlug=mc-mods&projectID=297361
MIT License
16 stars 5 forks source link

World Creation Crash w/ Custom Added Modded Biomes #14

Closed WenXin20 closed 5 years ago

WenXin20 commented 5 years ago

Forge v14.23.5.2807-1.12.2 Climatic Biomes v2.6.0 Mubble v1.3-pre4

I get this crash whenever I add the following biomes to the config. The biome names are the same as the ones listed in the BiomeList.txt. At first I thought it had to do with the space in the biome id, but then the landfill biome from Dumpster Diving also crashed it. Or am I doing something incorrectly? biome(mubble:mushroom kingdom) seed(mubble:mushroom kingdom, 20, biomesoplenty:tropical_island)
in the SpecialIslandWarm.cfg in the custom folder

The same crash also happens with this: biome(dumpsterdiving:landfill) in the plains.cfg in the custom folder

Crash Report

BlackJar72 commented 5 years ago

I see the problem -- "mubble:mushroom kingdom" doesn't work because it treats spaces as delimiters, so it's trying to create an entry where "mubble:mushroom" is followed by the number "kingdom" and then the name "20." I could probably re-work it to using the parser I made for Doomlike Dungeons and allowing strings with space to be put in quotes. I'm not at home now, but maybe I could do this in the evening.

Personally, I think whoever made that biome made the mistake by putting white space inside the resource name, but I'll try to support it.

BlackJar72 commented 5 years ago

Try the new 2.6.1 version and let me know if that fixes your problem. You will need to put quotes around all biome names with spaces in them for it to work.

EDIT: If you still have trouble with the dumpster diving mod you might want to bring it up there; it shouldn't be affected by this.

WenXin20 commented 5 years ago

I still get the same crash. These crashes: "mubble:mushroom kingdom" dumpsterdiving:landfill But this one from the same mod works, even without quotes. "mubble:scarlet forest"

BlackJar72 commented 5 years ago

Well, that doesn't make a lot of sense. Could you post the actual error reports for each and the config files you're using? -- maybe even the biome lists. If I can make it work it at all (no promises at this point), that could be very helpful.

BlackJar72 commented 5 years ago

Capitalize "Mushroom Kingdom" ("mubble:Mushroom Kingdom") for one thing (EDIT: That's how it is in the Mubble source code). I don't see any scarlet forest in the Mubble source code. I've contacted the Mubble author for clarification on this.

I'm not sure about landfill; that mod does not have available source code.

You are putting each entry on its own line, right?

Hugman76 commented 5 years ago

Hello there!

My mod actually uses the Scarlet Forest, and since the version is Mubble v1.3-pre4 it means it is actually a beta and by further more the source code for my betas is located on the dev branch. So the file is here. Also, it seems like I did pretty much a big mistake by actually doing the registry name of the biomes, because at the time I thinked this particular string was actually the name that would show up and not the internal ID.

Further more, I fixed this issue for v1.3-pre5, that will air soon. The biome IDs will actually be mubble:mushroom_kingdom and mubble:scarlet_forest.

Thank you!

BlackJar72 commented 5 years ago

Thanks for the fix!

BlackJar72 commented 5 years ago

If there is nothing more to say then I'm closing this here, too.