search

BlackJar72 / ClimaticBiomePlacement

An landmass generator and biome provider for Minecraft
https://minecraft.curseforge.com/projects/climatic-biome-placement?gameCategorySlug=mc-mods&projectID=297361
MIT License
16 stars 5 forks source link

World crash when minecraft biomes are disable. #21

Closed CapturedCherry-zz closed 5 years ago

CapturedCherry-zz commented 5 years ago

When I disable minecraft biomes in the mod config the world will crash on world gen. I tested this with both Traverse and Biome of plenty. Both of them crashed at the same point with the same crash log.

Crash log https://pastebin.com/bipZJHyH

BlackJar72 commented 5 years ago

I'll have to look at that -- the first thing that comes to mind it there may be a biome type that lacks biomes -- which would crash. If it has no biome to select for a type it will crash (thus the warning in the config itself). This results in division by zero when it tries to select from 0 of 0 biomes.

Remember, if you turn off vanilla biomes you are actually get rid of all of them (including oceans, rivers, and beaches, and other technical or easy to forget biomes), plus the default use of biomes from this mod.

One problem does come to mind also -- I'm not sure if I have a way to substitute in new beaches.

BlackJar72 commented 5 years ago

Actually, I should probably remover that option -- and if you don't want them just clear out the files that add them.

CapturedCherry-zz commented 5 years ago

Ok thanks. I have try so many ways to remove most of minecrafts biomes so I could use a different mod instead. There are mods that let you replace the minecraft biomes with one biome but its only one biome so that's no uses.

BlackJar72 commented 5 years ago

The way you'd do that with this is to edit the files in config/ClimaticBiomes/BiomeConfig/Minecraft, replacing the vanilla resource locations with the modded ones.

The thing you have to be careful about is simply this: Unless it's already empty for vanilla anyway, you must have at least one biome available. Empty lists crash.

BlackJar72 commented 5 years ago

The last couple versions, uploaded today, should be a bit more robust/resilient -- though empty biome lists will be refilled with vanilla biomes as a failsafe, so off vanilla biomes without making sure all lists have at least one biome may not always get the results you expect.