BlackJar72 / ClimaticBiomePlacement

An landmass generator and biome provider for Minecraft
https://minecraft.curseforge.com/projects/climatic-biome-placement?gameCategorySlug=mc-mods&projectID=297361
MIT License
16 stars 5 forks source link

[Doubt] Question about Performance in 1.12 #55

Open gatoborrachon opened 3 years ago

gatoborrachon commented 3 years ago

well, i really love the result you get when combine ClimaticBiomes+RecurrentComplex, but a friend tested how much we lost in performance with this mod and he told me that the chunks load very slow with this mod, i tryied it and it was true.

(i need to clarify that i just made 1 test for time reasons, but i will confirm this with more tries.)

1.- When i use /forge gen to generate 1000 chunks with Climatic Biomes, it taked almost the triple of time to make it, (it loaded 500 chunks in like 4 minutes, but it crashed because of another issue with another mod)

but without ClimaticBiomes it taked 3 minutes to gen the 1000 chunks

i know that we can expect a performance impact with the beautiful result made by ClimaticBiomes and it may worth it, but is this performance impact something we can expect? you know about possible incompatibilities that make this?

BlackJar72 commented 3 years ago

Which chunk generator were you using (which world type, climatic-realistic or climatic vanilla)?

Anyway, chunk generation should really be uneven. As long as you aren't moving to a new continent map it should actually be faster but whenever you first generate a chunk in a new continent there will be a lag spike. I never tested the what the net result would be for generating a large area all at once.

gatoborrachon commented 3 years ago

Which chunk generator were you using (which world type, climatic-realistic or climatic vanilla)?

sorry i forgot that, i was using Climatic Realistic,

I never tested the what the net result would be for generating a large area all at once.

mmm, well the test with /forge gen was to have a control test and compare with and without ClimaticBiomes, but in general you can see how it takes its time to generate chunks when you walk over new chunks, and without ClimaticBiomes it is like 2x faster.

anyways, i think that i need to do more test (only ClimaticBiomes without any other mod, for example), or maybe its my computer (i5 3220, 4.5 GB allocated from 8, Radeon HD 7850 of 1 GB of VRAM, Windows10) or even better, share you my personal modpack, but i really don't think that would help (if you want it no problem, i can upload it in mediafire)

BlackJar72 commented 3 years ago

I didn't know about /forge gen -- I don't think it existed years ago, since there use to be mods and apps for doing that.

But OK, now I've tested it, and it default and climatic vanilla both seem instantaneous, while climatic realistic takes a few seconds. I can't see where the command does anything either way though, teleporting to new areas that should be pre-generated still pauses to generate -- but oddly that only happens with default and climatic vanilla and not climatic realistic for some reason (?!?).

That is with /forge gen 0 0 0 1024 0

I'm not sure I can speed it up though -- I've already given up on cliffs in the climatic realistic worlds. I'm mostly an artist at heart who picked up some programming skills by modding. I'm not a trained or professional developer and seem to have reached the limit of what I can figure out in programming. This may be as good as it gets.

Sunconure11 commented 3 years ago

Try it against a larger modpack. If your computer does not explode, try my pack Compitum Magia, just for the sake of testing these issues @BlackJar72.

Pack has a lot of gen and yet I’m seeing a massive slowdown with realistic climatic biomes

Sunconure11 commented 3 years ago

Also, ask around the modded Minecraft discord server you are in, they have a 1.12 section

BlackJar72 commented 3 years ago

I have two idea where the lag might come from. One is that the way the influence of different around a chunk are averaged is complex and done for every block (or really column of blocks) -- though that is similar to how biomes are placed in a chunk, which doesn't seem to slow things (climatic vanilla doesn't have this problem). The other is that my noise generator is slow, being much less optimized than vanilla. I guess when I could try figuring out how to use the vanilla noise generators some time and see if that helps.