BlackJar72 / DoomlikeDungeons

A procedural multi-room dungeon generator for Minecraft
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1293843-doomlike-dungeons
MIT License
23 stars 12 forks source link

[1.7.10] empty chest generation #15

Closed Fabboz closed 6 years ago

Fabboz commented 6 years ago

Every time a dungeon spawn a large amount of empty chest are generated in empty chunks near spawn point (try deleting all the blocks of the spawn area with mc edit). Don't seem to happen in area loaded with a chunk loaded and not empty. The amount of chest increase at every dungeon spawn (can see with mc edit).

BlackJar72 commented 6 years ago

I don't have mc edit, but I may look into this when I can. The importance does seem limit though due to the age of the version and the strange circumstances required to produce it.

Fabboz commented 6 years ago

the chests spawn even if i fill the portion of map completely with bedrock.

BlackJar72 commented 6 years ago

OK, I'll download an x-ray mod and see if I can duplicate this -- though I can't imagine what could possibly cause something like that.

BlackJar72 commented 6 years ago

OK, confirmed. It isn't exactly near spawn, its near 0,0 -- specifically between 0,0 and 128, 128. I don't have time to deal with this right now, but I'll look into it when I can. Perhaps duplicating chest placements in that location?

Fabboz commented 6 years ago

Perhaps duplicating chest placements in that location?

Yes, exactly.

BlackJar72 commented 6 years ago

OK, it seems some code from newer versions was accidentally copied back to 1.7.10 at some point (perhaps by git?) -- this chest placement to be run twice, though once without the proper variable setting to make it work (so the were placed relative to the origin of the world map rather than the dungeon map).

It should be fixed now -- just waiting for Curse to approve the file.