BlackJar72 / DoomlikeDungeons

A procedural multi-room dungeon generator for Minecraft
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/1293843-doomlike-dungeons
MIT License
23 stars 12 forks source link

Fix NBT item generation not working, add a simpler NBT definition type #20

Closed Hubry closed 5 years ago

Hubry commented 5 years ago

After seeing a few packdev friends be really annoyed at how this mod works with NBT, I decided to help them.

I opted to bypass your tokenizer facility for parsing my addition because those strings vanilla Minecraft generates for NBT (they're basically just NBTTagCompound#toString()) use both whitespace and quotes, and I couldn't find a way to elegantly convert back with the method you used.

Also, I considered including a change to the repository structure to this PR to make future contributions easier, but I thought it was too invasive. Please consider moving the repository root to the root of your workspace to include your gradle buildscript and wrapper, so that future contributors only need to clone the repository and set up the Forge workspace, instead of having to set that up themselves and guess what MCP mapping you are using (it's not stable_39 as I discovered today).

BlackJar72 commented 5 years ago

Thanks, I'll test and upload this this evening.