Closed MyBlackMIDIScore closed 2 months ago
I'll review it soon, will be mostly afk all day, could you please review #59 which I somehow completely missed (or forgot about) until now, seems important if we want to publish this
I'll review it soon, will be mostly afk all day
No worries, I still have some stuff to add anyway which I'll do now
could you please review #59
Sure I just merged it locally and ran clippy and it seems to work fine so I'll merge it in GH. I also ran it with -Zbuild-std
to confirm and it's all good.
gtg for work, will finish the review later today hopefully
Made the requested changes. Also when you have time, take a look at the Cargo.toml
files to see if they are ok since I made some changes for publishing.
You've contributed enough that you can add MBMS to the authors list lol, but yeah lgtm
You've contributed enough that you can add MBMS to the authors list lol, but yeah lgtm
Lol thanks, I'll add it and merge this. Also after this I'll make a few last changes I want and then I'll make the 0.1.0 tag so you can release it on crates.
Was thinking that since now there is SF2 support and the synth is more complete we could start making version releases and potentially publish to crates.io.
Started off with the documentation since it is pretty necessary if we publish this as a crate. I also intend to maybe modify the readme a bit and add any other information necessary in Cargo.toml and stuff.
Although main point is to start "counting" versions from now on to better keep track of changes and the API to use XSynth in other projects. Let me know about your thoughts on this.