Use From instead of "2" methods

BlackPhlox / bevy_dolly

h3r2tic's dolly abstraction layer for the bevy game framework

Apache License 2.0

143 stars 22 forks source link

Closed janhohenheim closed 1 year ago

janhohenheim commented 1 year ago

Patch dolly glam to use same version as Bevy
Use From instead of methods with "2" in the name through the DollyTransform type (Fix #23)
Simplify code by using the prelude more extensively
Simplify code by using the type alias pub type DollyTransformType = dolly::transform::Transform<RightHanded>;
Add doc tests to CI
Run clippy for examples
Fix clippy warnings for examples
Simplify code by using vector shorthands in 2D cam move example
Simplify camera spawning in examples (Fix #24)

janhohenheim commented 1 year ago

Ready for review :)

BlackPhlox commented 1 year ago

Very nice 👍 it looks good, I've posted two questions in the review above

janhohenheim commented 1 year ago

I think you missed clicking on the "Submit review" button on the upper right, because I don't see anything yet 😉

BlackPhlox commented 1 year ago

I think you missed clicking on the "Submit review" button on the upper right, because I don't see anything yet wink

I'm sorry, my mistake, I'm still learning to use github 😅

janhohenheim commented 1 year ago

Woah, nice work on the PR, the ergonomics are way better now! :)