search

BlackPhlox / bevy_midi

Send and receive MIDI data to and from bevy using DAWS or MIDI Controllers
Apache License 2.0
56 stars 10 forks source link

Make input and output generic/minimize code duplication #15

Open BlackPhlox opened 2 years ago

BlackPhlox commented 2 years ago

Something like this can also be implemented for input, maybe we can do something more generic for both of them?

_Originally posted by @BlackPhlox in https://github.com/BlackPhlox/bevy_midi/pull/12#discussion_r939655190_

grace125 commented 2 years ago

I'm starting to think that while input/output should be more similar, it wouldn't make sense to make the APIs actually generic. There won't be much code duplication in the changes I'm going to propose.

BlackPhlox commented 2 years ago

Yeah, generic was the wrong word here. End goal is to minimize code duplication, not be made generic.

grace125 commented 2 years ago

Ah okay good, glad we're on the same page!