search

BlackSparowYT / Zelk-Discord-Theme-Fixes

A repository for the bugs that won't be fixed in the Zelk theme for better discord!
7 stars 0 forks source link

[BUG] Hoover on Tab seems broken after the last update #41

Open lmtivy opened 2 months ago

lmtivy commented 2 months ago

zelkthemmefix It seems like the recent update broke the fix. The Hoover Tab highlight color is reversed. Could you please take a look? I appreciate your work.

BlackSparowYT commented 2 months ago

Will be looked at when I have time. Thank discord for breaking it and thank you for reporting it!

tmprnc commented 1 month ago

I have made some temporary fixes to the theme that does fix the issue you're having in the mean time if you care to use them.

(Note: the text is still in an illegible font color when you hover the channel in the dark theme and I could fix it fairly easily but I'm too lazy and it's not important enough that I can be bothered to fix it)

There are several caveats to using this:

  1. It's using my custom font overrides, if you don't have them installed locally it should pull from the next one on the list, but realistically you should change your fonts yourself. To do so, replace the --font-display and --font-primary values with 'the name of your wanted font'
  2. I make several changes to the theme based on my tastes and include elements from other themes. This will not be vanilla Zelk as intended by the original author. Furthermore, I use it in conjunction with Vesktop and this acrylic theme — although only the ones that change the window+server bar and the flyout popups); this isn't at all necessary for the theme to work but there might be things that look fucky because we simply don't have the same look if you don't use that
  3. This is just extremely dirty and hacky code with overrides being put into the theme.css file and you really shouldn't do that if you want to write a clean theme. This is basically based on me seeing something that doesn't work, figuring out where is the problem and just adding a CSS rule to fix it. It's not a clean solution, more like a bandaid fix.
  4. This will probably break once something is fixed in either original Zelk or the fixes
  5. Installing it requires a slight bit of CSS technical know-how — which, if you have that, you probably would be capable of fixing it yourself in the first place maybe??

https://gist.github.com/tmprnc/5115abe835207ee7f234e9d9f353a495

lmtivy commented 3 weeks ago

Thanks. I fixed it by myself.