BlackToppStudios / Mezz_Foundation

Foundational Data types that enforce no opinions on how to build games and provide many facilities that complex games need. This largely avoids graphics and physics, but provides tools like the SortedVector, CountedPtr and HashedString classes.
GNU General Public License v3.0
3 stars 0 forks source link

Proposed starting point #7

Closed Sqeaky closed 6 years ago

Sqeaky commented 6 years ago

This builds but might not do everything ever other Jagati package does.

MakoEnergy commented 6 years ago

You seem to have some zealous copy pasta on line 34 of the root CMakeLists.txt.

MakoEnergy commented 6 years ago

The Readme.md seems to have gained a cmake configuration. Bold strategy.

MakoEnergy commented 6 years ago

BitFieldTools looks good logic-wise, but a couple minor styling gripes come to mind. 1) The newlines above and below the datatypes.h inclusion directive(lines 47 and 49). I don't see any constructive value for them. I DO see the value in indenting, just not the vertical spacing. 2) The access specifiers in classes/structs aren't worth their own indentation level, in my opinion. They account for only 1-3 lines per class/struct and not giving them their own indentation level helps us reclaim horizontal space (which I know you value more than I do).

MakoEnergy commented 6 years ago

My styling comments for BitFieldTools can be said of Streamlogging.h as well. In addition: 1) Line 102 (which is a comment) seems to have suffered from some zealous copy pasta. 2) Minor styling gripe, but I feel when masking the visibility of the operation is improved when there are spaces on either side of the operator. In fact I do this with most operators in executing code. It's helped me with replace operations, improved visibility, and avoids issues like the super arrow operator. That said, the masking done in the LogLevel enum may benefit from some spaces.

MakoEnergy commented 6 years ago

Lines 106 and 107 of loggingtests.h are using a TEST macro instead of a TEST_EQUAL. Also, should the filename be camel cased?

Sqeaky commented 6 years ago

Cool, I see these and I will Make changes to correct these later today.

Sqeaky commented 6 years ago

Fixed - line 34 of the root CMakeLists.txt. Fixed - Extra Cmake in ReadMe. Good catch, I feel sloppy letting that through Moving back access specifier and indented stuff

Reverting the file logging tests.

I will also try adding some CI to this so that we can have more assurance that this works in the general case.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b3fed74). Click here to learn what that means. The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #7   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      3           
  Lines             ?     46           
  Branches          ?      0           
=======================================
  Hits              ?     46           
  Misses            ?      0           
  Partials          ?      0