search

BlackZork / mqmgateway

MQTT gateway for modbus networks
GNU Affero General Public License v3.0
44 stars 20 forks source link

Topic name #54

Closed ban-devso closed 4 months ago

ban-devso commented 4 months ago

delete mState

BlackZork commented 4 months ago

I am afraid that this PR cannot be merged. It does not compile, so I cannot run unit tests. It contains many unrelated changes: code style change (but only in one file?), some test code that publishes yaml formatted data to a hardcoded MQTT broker. Changes to published MQTT topics are not backward compatible and will break existing configurations.

You need to split this PR into separate PRs. Each PR should contain a single fix or feature. All existing unit tests must pass. For new features, there should be one or more unit tests that verify this new feature works in basic scenarios. Backward compatibility must be preserved.