search

BlackbitDigitalCommerce / pimcore-data-director

Import Bundle for Pimcore
16 stars 3 forks source link

Brick import with 0 integer values #104

Closed ascheider closed 1 year ago

ascheider commented 1 year ago

Currently it is not possible to import brick if mapped value is equals 0 because of following code in Importer.php: image If you dump variables, then integer zero is casted to float 0 and empty returns true, so brick creation is skipped: image image If i change value to 100 for example and rerun import: image image image So the valid integer value can currently not be imported in bricks. I don't know if the problem also exists in another importer areas. Empty is heavely used in importer.php

Files to reproduce (as txt github does not allow json): objectbrick_CF00010_export.txt class_TestClass_export.txt importtest.txt

BlackbitDevs commented 1 year ago

Thanks for your detailed report. Is fixed in 3.4.3. Can you please check and close this issue, if it now works as expected?

ascheider commented 1 year ago

@BlackbitDevs Works now. Thanks!