search

BlackbitDigitalCommerce / pimcore-data-director

Import Bundle for Pimcore
16 stars 3 forks source link

Feature Request / Discussion: Inheritance optimisation for Classification Stores #105

Open Alanin opened 1 year ago

Alanin commented 1 year ago

Hi there,

Thank you for that powerful toolset you provide with this bundle. It’s really awesome!

At the moment a have to import a lot of flat data for a customer. Most of the data has to be added to values in a classification store.

For bad luck the inheritance optimisation is not implemented to work with the classification stores.

Now my question, is this feature planed in the future? Or is there a reason it’s not implemented yet? Maybe it’s way to difficult or something like that?

Because I do need that functionality kinda asap I would like to implement it myself. Maybe its ok to implement that into the data director, cause it’s doing a great job on the other fields.

If it’s ok, could you please give me some hints to where to start? Are the coding guidelines or guidelines for the structure etc…

Thank you a lot Alanin / Jörg

BlackbitDevs commented 1 year ago

Hi Jörg,

indeed the "Optimize inheritance" feature currently does not work for classification stores.

Now my question, is this feature planed in the future?

I have added it to my todo list but it currently does not have highest priority. If this feature is critical for you, please write an email to info@blackbit.de, then we will send you an offer which then of course will be handled with high priority.

Alanin commented 1 year ago

Hi @BlackbitDevs,

thank you for your answer. After reading some code I have found out that you are using the core functions the get the diffs of objects and that the classification store values do not have that methods implemented.

i have written some functions to accomplish the detection. Maybe it will be allowed to share the code. then you could implement it in the data director (if it fits ;))

BlackbitDevs commented 1 year ago

Sounds great @Alanin ! I have given you write permission to https://bitbucket.org/blackbitwerbung/pimcore-plugins-data-director/ - please submit your changes as pull request (with base branch 3.4).