search

BlackbitDigitalCommerce / pimcore-data-director

Import Bundle for Pimcore
16 stars 3 forks source link

Compatibility with Pimcore Light Theme #140

Open studio1gmbh-pimcore opened 5 months ago

studio1gmbh-pimcore commented 5 months ago

Hi,

when using data director with the Pimcore Light Theme some UI elements does not fit into the new style or even break the ui.

image Problem: icons does not match the style of other main menu entries and should not be inverted Suggestion: use monochrome icons shipped with pimcore. Since pimcore use an invert filter for the light theme, they will work with both, light- and dark theme (https://github.com/pimcore/admin-ui-classic-bundle/tree/1.x/public/img/flat-white-icons)

image Problem: text on selected fields are not readable, because data director style is overwriting pimcores default style for select fields in /Resources/public/css/pim.css

.x-boundlist-item-over, .x-boundlist-selected {
    background-color: #3c3f41 !important;
}

Suggestion: check if this css property is still needed and remove it

Thanks in advance. :)