BlackbitDigitalCommerce / pimcore-data-director

Import Bundle for Pimcore
16 stars 3 forks source link

skipExtract #94

Closed betterapp closed 1 year ago

betterapp commented 1 year ago

As I see there is extra param skipExtract but I can not find anything about it in DD documentation.

image

betterapp commented 1 year ago

When I use skipExtract=1 it looks like it take all rows data and it took 3x more time then the same query without this param

for what skipExtract param is used ? Why we have difference in data count ?

image

betterapp commented 1 year ago

As I checked skipExtract=1 param causes to read data from tables:

image

And looks like it read ALL rows from this tables for specific dataport.

What I see is that when we Delete row data and try to run API call which should export data we got:

No dataport resource IDs given

in the response and DataDirector create empty process image

that will run forever. Need to be canceled manually.

I checked it on 3.2.35 DD.

BlackbitDevs commented 1 year ago

skipExtract is not used anymore. You only found some dead / unsupported code, I will remove it. It was indeed once used to execute dataports via REST API with existing raw data. For exports nowadays this is possible when you enable "Run automatically on new data" (then the raw data will automatically get updated as soon as a corresponding object gets saved). And for imports skipExtract does not make sense as it causes unpredictable results as you won't want to run an import without unknown raw data.