Open hitsoul11 opened 1 month ago
This would mean that we also have to add the corresponding translation, otherwise the button label would be initially "sso_button_provider.My SSO provider". Currently it is implemented similar as for Pimcore data objects - there actually also the field titles get used as translation keys but if you do not translate them, you will simply see the field titles.
Ok, understood. Maybe you can add an additional provider config value for the translation key / button label and set it to the provider name as default.
Before I do that, I would rather create the translation key and assign the provider name in all languages ;-)
But what is the actual problem why you want the prefix? Because usually when somebody wants to change a translation, he goes to translations, searches for the currently visible (wrong) translation and then changes it. Nobody will search for the key because this is most often not even visible.
We set our provider's name to company/customer name. But we would like to label the sso button to "login with [company]". So, it's easy to set a translation for company name to "login with [company]". But we also use the company names in different contexts like in data objects / option field (labels), .... Do you recommend to name the provider as "login with [company]" instead of "[company]"?
Hi there,
currently the provider name in the login button is translated without any prefix. In my opinion it would be better to prefix the translation key with something like
sso_button_provider.[providerName]
.