23 combine windows

[Blackbluue]

Summary by Sourcery

This pull request refactors the GUI by combining the map window and dashboard into a single window, simplifying the structure and improving code maintainability. It also replaces the LabeledCounter class with the Counter class for managing game counters and updates the Dashboard class to better integrate with the main window. Additionally, it removes obsolete code and files.

• Enhancements:
  • Refactored the main controller to combine the map window and dashboard into a single window, simplifying the GUI structure.
  • Replaced the LabeledCounter class with the Counter class for managing game counters, streamlining the code.
  • Updated the Dashboard class to inherit from tk.Frame instead of tk.Toplevel, integrating it more closely with the main window.
  • Removed the legend insertion and map window handling from the Dashboard, focusing it solely on game data display.
• Chores:
  • Deleted the obsolete map_window.py file, cleaning up unused code.

[sourcery-ai[bot]]

Reviewer's Guide by Sourcery

This pull request refactors the GUI and game logic to remove the MapWindow class and replace it with MapData. It updates the event bindings to use the root window and adjusts the layout and initialization of the GUI components. Significant changes include the replacement of LabeledCounter with Counter, the addition of _map_frame for map display, and the removal of the MapWindow file.

File-Level Changes

Files	Changes
gui/main_controller.py gui/dashboard.py units/ally/player.py utils/game_data.py units/ally/overlord.py units/ally/atron.py	Refactored the code to remove MapWindow and replace it with MapData, updated event bindings, and adjusted the GUI layout and initialization.

---

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.