Closed GoogleCodeExporter closed 9 years ago
The problem with editing comments is that change the conversation, so we
decided that cannot be done. The other issues might be easy to do. What do you
think, Michael?
Original comment by a...@villagescribe.org
on 27 May 2014 at 6:27
Original comment by a...@villagescribe.org
on 27 May 2014 at 6:28
deleting same comments that are published several times by mistake seems to be
a database clean-up operation and can be done quite easily. I think we should
introduce code that identifies if a comment exist already before adding it, if
they are right next to each other:
if comment string to be added is same as the previous comment string then do
not add.
I would only apply this exists already check on the previous comment because
somebody in a "comment conversation" might repeat the comment on purpose in
order to make a point to another comment.
I personally would not clean up the database since the comments as they age
will be less important but I would add the check for new comments soonish.
Original comment by appiapp...@gmail.com
on 27 May 2014 at 11:25
I agree to all you suggestions, Michael.
Original comment by a...@villagescribe.org
on 27 May 2014 at 11:47
Original comment by a...@villagescribe.org
on 2 Jun 2014 at 12:55
Original comment by a...@villagescribe.org
on 11 Jun 2014 at 11:22
I think I did change the code already to check for double entries will check
and upload it so that it can be tested.
Original comment by appiapp...@gmail.com
on 12 Jun 2014 at 7:17
Thank you. Please, let Antje and Rieke know what to test. They have no sessions
at the moment and spend all their time in the office.
Original comment by a...@villagescribe.org
on 12 Jun 2014 at 7:51
I made the necessary code modifications in the Comment model of the Comment
module. I added a check in the verify method that only allows a comment to be
saved if it differs to the comment that was previously made.
I am busy updating svn and will upload changes to mothsorchid as soon as it is
available again.
Original comment by appiapp...@gmail.com
on 18 Jun 2014 at 1:41
I have uploaded the comments changes to mothsorchid.com, please test.
It should now not be possible to add an identical comment (one that is equal to
the latest comment) to an item (blog, picture, video, audio, etc.). However it
is possible to add a comment that is identical to the comment made before the
latest comment.
Original comment by appiapp...@gmail.com
on 25 Jun 2014 at 7:30
I successfully tested with my admin, teacher and student account. Everything
worked out as described.
Original comment by antjeh...@gmail.com
on 30 Jun 2014 at 7:43
Shall I update awarenet.eu so that that functionality is working there as well?
Original comment by appiapp...@gmail.com
on 30 Jun 2014 at 11:37
I am sorry that we could not help. Testing and working with awarenet issues was
part of the practical course for the new volunteers last week, but then we
suddenly had no access to neither awarenet nor mothsorchid, so that fell off
the agenda.
Well, I am glad it works again and Antje was able to test. :-) So, yes, please,
update awarenet.eu as well.
Original comment by a...@villagescribe.org
on 1 Jul 2014 at 7:47
comments changes are active on awarenet.eu now. I tested it and it works.
Original comment by appiapp...@gmail.com
on 2 Jul 2014 at 8:20
Hmm, perhaps Antje's request was not clear enough, but in the first line she
asks if the response field can be placed above all the comments, so that users
do not have to scroll down all the way to reply.
I am missing the button to retract a comment. Strix argument was that one
should not be allowed to edit a comment when it is part of a discussion,
because one can then take the sense out of a discussion. I remember that the
idea was that comments should only be allowed to be edited for about 5 minutes
after the first publication. After that, they can only be retracted.
Original comment by a...@villagescribe.org
on 2 Jul 2014 at 8:37
I am busy moving reply field up, retract button is visible/accessible and
workable with me, how can this be that it is not available to you?
5 minute edit lapse is not implemented I think. Can you please open up a new
issue for that should we need this functionality?
Original comment by appiapp...@gmail.com
on 2 Jul 2014 at 9:16
I moved reply field to top right. Please check on Mothsorchid if it is okay
like that.
Original comment by appiapp...@gmail.com
on 2 Jul 2014 at 10:20
I am not sure what happens here at the moment. :-) But I guess, it's just a
misunderstanding. I will try to explain better this time with a screenshot.
I have added a comment/reply to a discussion. I expected the field to do that
to be on top of the discussion thread, but below the initial
question/introduction right on top, but it still is placed below all posts.
I remember a button to retract a comment/reply under the post, but I can only
see [edit] and [report], but perhaps there was never a button like that...?
http://mothsorchid.com/forums/showthread/Coraline
Original comment by a...@villagescribe.org
on 2 Jul 2014 at 11:17
Attachments:
The misunderstanding is that the heading of the issue lead me to deal with
comments, which are comments to postings of all kind (blog, video, pictures).
Now I can see that we are addressing issues that concern discussions, which is
a different module I believe and has probably not much to do with the comments
that I looked at.
So what I suggest is to check the comments changes I made for the last time on
mothsorchid and let me know if this is okay like that (I moved the reply to top
right now so that replying to a comment is absolutely obvious)
For the discussion issues I suggest that you open up a new issue for the
discussion module so that I can deal with the issues over there.
Original comment by appiapp...@gmail.com
on 2 Jul 2014 at 11:29
Yes, Michael, you are right. I created Issue 388 for forum discussions. Anna
explains exactly what I wrote there.
For the comments, I wanted the response field to appear at the top. Imagine
there are already 30 comments below a picture. The learners clicked on [reply],
but couldn't find the response field to answer, because it apperared below all
the 30 comments. They didn't know that they had to scroll down. So it would be
great, if the response could appear on top.
Original comment by antjeh...@gmail.com
on 2 Jul 2014 at 11:41
Attachments:
The comments look great and work fine and can be retracted. :-)
Antje, please let us know if you were talking about comments or discussion
replies. - Surely my misunderstanding as I have never seen so many comments
under a picture that I had to scroll down. I also saw Antje's test comments on
mothsorchid.
My personal opinion is that comments to not need to be editable. Most of them
are really short. But since this is Antje issue, please give us your opinion.
I have also tested to post the same comment twice, which does not work, so
that's great. I wonder if there should be some kind of message saying that the
comment wasn't posted, because it was a replicate?
Original comment by a...@villagescribe.org
on 2 Jul 2014 at 11:43
We only had this problem when Terri let the learners comment on a picture for
the Health and fitness project instead of creating a forum discussion. There
were so many replies that it was hard to find the response field for the
learners.
http://awarenet.eu/gallery/image/index.jpeg-luaxu and
http://awarenet.eu/gallery/image/index.jpeg-wr2bh
Normally there are not that many comments.
I thought it would be nice to edit comments, because some learners published
their comments by mistake or wanted to correct spelling mistakes. None of them
wanted to change the meaning of the comment. But I definetely see the point
that it could change the conversation.
Original comment by antjeh...@gmail.com
on 2 Jul 2014 at 2:56
Ok, so let's leave it and not make it possible to edit a comment, but change
the direction of replies, newest on top along with the response field.
Original comment by a...@villagescribe.org
on 3 Jul 2014 at 7:08
COMMENTS!:
I changed direction of replies so that latest reply is on top and the response
field is now on top as well.
Please test and let me know when I can upload it to awarenet.eu.
Original comment by appiapp...@gmail.com
on 18 Jul 2014 at 1:44
It looks to me as if this is what Antje wanted.
Original comment by a...@villagescribe.org
on 21 Jul 2014 at 6:09
I will upload it now to awarenet.eu
Original comment by appiapp...@gmail.com
on 21 Jul 2014 at 10:37
active on awarenet.eu
Original comment by appiapp...@gmail.com
on 21 Jul 2014 at 10:39
Original comment by a...@villagescribe.org
on 21 Jul 2014 at 10:59
Original issue reported on code.google.com by
antjeh...@gmail.com
on 26 May 2014 at 9:53