Blackixx / BossShopPro

BossShopPro is one of the most player-friendly and multifunctional GUI plugins ever! Say goodbye to all the annoying command- or signshops!
https://www.spigotmc.org/resources/bossshoppro-the-most-powerful-chest-gui-shop-menu-plugin.222/
MIT License
43 stars 63 forks source link

Console Spam in 1.14.3 #23

Open mercurialmusic opened 5 years ago

mercurialmusic commented 5 years ago

Getting this error spam in console using BossShopPro 2.0.7 on CraftBukkit version git-Spigot-d05d3c1-604c8bf (MC: 1.14.3) (Implementing API version 1.14.3-R0.1-SNAPSHOT).

https://gist.github.com/mercurialmusic/be34a039838c52b28f572afd75464b07

Thanks!

mercurialmusic commented 5 years ago

The issue persists in 2.0.8. Seems to happen every time someone opens a chest -- which is a lot. And also kinda bizarre.

mercurialmusic commented 5 years ago

We've noticed this one is really starting to affect server performance when players have chests and hoppers connected to a decent amount of furnaces. Would greatly appreciate a fix soon!

Blackixx commented 5 years ago

Seems like the issue is connected to the ServerPinging feature. A quick workaround for you might be instead of using BSP ServerPinging, using another way to get the player count (some PlaceholderAPI extension) and then use placeholders to add the playercount to shops.

mercurialmusic commented 5 years ago

Confirming that disabling server pinging fixed the issue. Thanks!