Blackmorse / hat-all-stats

new alltid
11 stars 4 forks source link

[Question] data sharing #282

Open akasolace opened 3 years ago

akasolace commented 3 years ago

Hello,

I am the maintener of HO!. I want to introduce in the league tab, information about max/average HatStats for each teams. I could either develop it in the app or I could if you accept it get information from your site (I would obviously credit you for this). I really don't expect that you see a noticeable traffic change from this. What do you think?

Blackmorse commented 3 years ago

@akasolace Hi! Thanks for developing HO, before I buy a supporter I couldn't imagine Hattrick without HO :)

We can try to do this, I can share Hatstats endpoint to you. But

  1. I have not such powerful server for my site, so I will need to monitor how much requests there will be, and how it will handle them
  2. My site is not 100%-stable, so please take this in account, that this endpoint may not work from time to time.

Anyway, you are welcome, I will be happy to help you with this

akasolace commented 3 years ago

Thanks for developing HO, before I buy a supporter I couldn't imagine Hattrick without HO :)

Thank you for the kind word. Similarly, I always loved Alltid and I am glad you revived it. (Don't know if it would be easily feasible or not for you but one of my favorite alltid feature was to compare rating among team that started the same week or month, it was cool to know that while suffering in our league we were doing pretty great versus people starting the same time than us :-))

I have not such powerful server for my site, so I will need to monitor how much requests there will be, and how it will handle them

According to HT stats, there is around 20 000 active users of HO!. Personaly, I nevel collected data but I believe this to be greatly exaggerated. Also for your info, we have a small server for HO!, the free plan of Anvil.Works (we are using it for promotion/relegation calculation) which always handled the charge. In any case, we can give it a try and if it cause you problem we stop it immediately.

My site is not 100%-stable, so please take this in account, that this endpoint may not work from time to time.

No problem, we are used to CHPP downtime :-)

Anyway, you are welcome, I will be happy to help you with this

Looking forward giving it a try.

Thank you

PS: on a side note, I came across your other project https://github.com/Blackmorse/hattrick-java-api. That part of the code in HO! is almost 20 years old and it has been on my to do list for a while to refactor it. I never found the time, but I might slowly move to your library considering all you have already done. However, requirement on HO! side are larger. If I were to start this, would you prefer me to use your library and submit PRs or would you prefer me to fork it ?

Blackmorse commented 3 years ago

my favorite alltid feature was to compare rating among team that started the same week or month

Yes, I have plans for this also. I guess sometime I will implements this :)

In any case, we can give it a try and if it cause you problem we stop it immediately.

Sure. I will send your an email with instructions of using the endpoint. Your are welcome for any questions :)

Blackmorse commented 3 years ago

on a side note, I came across your other project https://github.com/Blackmorse/hattrick-java-api. That part of the code in HO! is almost 20 years old and it has been on my to do list for a while to refactor it. I never found the time, but I might slowly move to your library considering all you have already done. However, requirement on HO! side are larger. If I were to start this, would you prefer me to use your library and submit PRs or would you prefer me to fork it ?

I think It will be better to submit a PRs, so that we will have one up-to-date version. Also I guess you want to have more "files" at this library, right?