Blackstareye / toggleAudio-blackeyeprojects.de

Gnome Extension for toggling audio
6 stars 0 forks source link

Hotkey support #3

Closed hrandib closed 2 months ago

hrandib commented 2 months ago

It would be useful to have an option to set hotkeys for

Blackstareye commented 2 months ago

I will look into that and if it is suitable there. Global Hotkeys are kinda fuzzy sometimes.

Blackstareye commented 2 months ago

Review is pending :) You can test it @hrandib if you want (using the branch feature_hotkeys. Or you wait until the review is passed :)

Meanwhile: I would appreciate it if you let a review here if you got time for that review :)

hrandib commented 2 months ago

Works fine for me except one thing, can't set a custom hotkey via dconf-editor. Maybe more instructions will help. The extension is installed by replacing content in the .local/gnome-shell with PR. Screenshot from 2024-07-10 19-38-04

Blackstareye commented 2 months ago

Ahh I see. They are not visible until they are changed. I will look into that.

But this needs a bit of time. I have to check that :D

PS: thx for the review ^.^

Blackstareye commented 2 months ago

@hrandib Okay. I will add it to the readme but please find an instruction here: hotkeywiki

Hope that helps :)

Blackstareye commented 2 months ago

I will wait until you confirm you understand my instructions :) . Then I will close this issue :)

Blackstareye commented 2 months ago

jtaala from the matrix channel mentioned that this is a bug in dconf-editor (https://github.com/paperwm/PaperWM/issues/887) So you can use dconf editor as well :) I put the necessary codeline in the wiki entry :)

hrandib commented 2 months ago

The first approach works fine for me but not the second, no luck with dconf-editor: GSETTINGS_SCHEMA_DIR=::$HOME/.local/share/gnome-shell/extensions/toggleAudio@blackeyeprojects.de/schemas dconf-editor

(dconf-editor:387468): CRITICAL : 08:47:02.851: source_manager_try_prepend_dir: assertion 'schemas_dir != NULL' failed Segmentation fault (core dumped)

hrandib commented 2 months ago

I'm on Ubuntu 24.04

Blackstareye commented 2 months ago

Weird. But I can't help you there. I link you to the matrix channel and the issue :)

Issue: https://github.com/paperwm/PaperWM/issues/887

Matrix Channel: https://matrix.to/#/!hCGqHbXRuMrvWnudnP:gnome.org/$cA5eRVwJmeQVm3okUVenlALcSGdTUchdi__xyIYuz5w?via=gnome.org&via=matrix.org&via=envs.net

Linked Bug: https://gitlab.gnome.org/GNOME/dconf-editor/-/blob/master/editor/source-manager.vala#L127

Hope they can help you there :)

Matrix Link for gnome extension is this one: https://matrix.to/#/#extensions:gnome.org

I am glad that it worked with the first approach though :> Enjoy your hotkeys ! :D

I will close this one, soon then :)

hrandib commented 2 months ago

The result is achieved, the only issue is the hotkey setting is a bit inconvenient. Anyway thank a lot for the support