Blackstareye / toggleAudio-blackeyeprojects.de

Gnome Extension for toggling audio
7 stars 0 forks source link

Monochrome icon #8

Closed goat865 closed 3 months ago

goat865 commented 3 months ago

As the other buttons have monochrome icons, I think it would be great if the extension had at least an option to switch between colored and monochrome icons.

Blackstareye commented 3 months ago

Hey :),

I am using these icons https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/blob/217878386a44d2332d4ad3ed24ed36cc50c7fcdb/extension.js#L95-L100

which is this one grafik

and that one grafik

so it is monochrome.

but if you have another icon suggest for these, just mention it here and I can test its look :D

Ps: But I saw, that they are different "shown" depending on the OS. On Ubuntu they are sometimes colorful depending on the theme.

goat865 commented 3 months ago

Well look at that, you're right. I'm using Kora as my icon theme and apparently it changes the icon of your extension as well.

image

I wonder why not to a monochrome icon like the others tho.

Blackstareye commented 3 months ago

strange 😄 maybe, you can file an issue to the theme so they are aware of that ? afaik there is also a flatpak called icons which shows all available icons. Maybe you can see there if your package contains other not monochrome icons as well and if it is a design choice :D

in case you want all icons be monochrome :)

Blackstareye commented 3 months ago

@goat865 i saw that there are also symbolic icons. So i changed it and made another panel for styling.

I also got a bit of time this weekend, so I also made it possible (its not bugfree because of wrong input --> wrong output) to change the icons as well. They are now a gsetting:

grafik

PR is this one #9

it will be available soon. I will pack it, test it and then it's available as soon as it is approved by gnome :)

Blackstareye commented 3 months ago

@goat865 good news it's approved :D

goat865 commented 3 months ago

Great, that was fast. Thank you :)

Blackstareye commented 3 months ago

@goat865 hope it's now more controllable for you which icon is shown :D

goat865 commented 3 months ago

Yeah, I hope so. I'll let you know once I get home.

goat865 commented 3 months ago

Everything looks good, thanks again :D