search

Blackstone-SS13 / BLACKSTONE

GNU Affero General Public License v3.0
29 stars 185 forks source link

Mortician better shovel vs undead #1188

Closed singularshamble closed 1 month ago

singularshamble commented 1 month ago

About The Pull Request

Gives Mortician an edge against zombies and skeletons when 2-hand-chopping with their shovel. Supposed to increase damage and create the same knockdown and stun effects that silver dagger does to werewolves and vampires.

Also makes the shovel part of the polearms group and gives Morticians Journeyman-level polearms skill to make them pretty good with their shovel.

Shovel is otherwise normal vs. other entities. Morticians that pickup another polearm are Journeyman-level with it, but only the shovel gets that gudgud.

Why It's Good For The Game

Gives the Mortician: 1) A somewhat better defense against zombified corpses/ambush zombies and skeletons. 2) Another way to go about the round if they don't want to be just burying bodies and want to actively serve Necra by pre-emptively banishing undead before people are hurt 3) More of a reason to be brought along to the action by the Priest/the King when undead attack.

To wait around in/near the graveyard for the few hours that make up a round can sometimes be very void of activity; between burials Morticians often spam-pray (which I'm not saying is a problem), fend off people trying to steal dead-person loot, and waiting for the next body. By buffing the shovel a bit and only against undead mobs, the Mortician may now have the option to go out and either look for bodies or do more local burials in the Bog Town, and they won't be as easily killable by bodies they're trying to bury.

Could also make it so that only Morticians get this boon, not just anyone who gets their hands on the shovel. Up to devs.

AT PRESENT: The code works when I test it locally, but I don't see an improvement in damage vs the spawned in skeletons and zombies. I might be testing wrong. If someone could have a look and see if there's something I'm missing, I'd greatly appreciate it!!

Thanks!

dunsel-hordon commented 1 month ago

The mortician shall become the shovel knight but real talk that damage for the shovel base 30 for everyone is wild go look at the dragon necklace for bandits and make it exclusive to morticians

Gyrandola commented 1 month ago

No the way this is implemented is just powercreep. If I spawn with journeyman polearms as a mortician ill just go buy myself a halberd. Instead leave their skills as is but add specific on_hit interactions to their shovel. Right now it's a -1 from me.

ChungusGamer666 commented 1 month ago

The shovel is a tool, not a crazy weapon that should be the bane of undead. I am open to the idea of having a silver shovel or something that actually smites undead, but giving morticians polearms skills is frankly bizarre and making this tool of the trade made from common iron capable of destroying undead is seriously stupid.