search

Blackstone-SS13 / BLACKSTONE

GNU Affero General Public License v3.0
29 stars 186 forks source link

Fix sewage not making noise when you walk on it #1250

Closed monad76 closed 4 weeks ago

monad76 commented 1 month ago

About The Pull Request

Fixes #1008 Currently there is nothing that checks for when a player enters sewer water, this change simply adds that check and plays the appropriate sound for water movement. Since sewer water is shallow I omitted the splash sound effect on initial entry.

Why It's Good For The Game

As stated in the issue players can run in water to completely mute themselves while being chased through the sewers which makes it much harder to track them given how dark it already is. Also everything should give some form of basic feedback to the player in some way.

BlueMemesauce commented 1 month ago

If you're going to do this then just update it in the parent so that shallow water still gets a sound

monad76 commented 1 month ago

If you're going to do this then just update it in the parent so that shallow water still gets a sound

yeah good point, it's been changed.