Blackstone-SS13 / BLACKSTONE

GNU Affero General Public License v3.0
29 stars 186 forks source link

Alchemy (and Bombs) #1256

Closed Hmeister-real closed 3 weeks ago

Hmeister-real commented 1 month ago

About The Pull Request

Adds alchemy, makes it possible to craft Bottle bombs, Manna and health potions, also in bulk. Allows for future implementation of actual potion making using this as a template. Also adds chemistry to a lot of roles, and changes some stats about. Notably for sorceress since they were using shit-stats from zeth era roguetown ## Why It's Good For The Game Potion making is fun :) Also bomb making is REALLY fun :D
CVSthePharmacy commented 1 month ago

how will you level it up

dunsel-hordon commented 1 month ago

there already is a mortar and pestle

Hmeister-real commented 1 month ago

how will you level it up

making fire bombs 🧌, just needs 11 int for the 2% chance

lovegreenstuff commented 1 month ago

why do you need bowls instead of bottles

Hmeister-real commented 1 month ago

why do you need bowls instead of bottles

i think it's the bottles it just has a weird name. Unless im wrong, then direct me to where the bottles are

lovegreenstuff commented 1 month ago

why do you need bowls instead of bottles

i think it's the bottles it just has a weird name. Unless im wrong, then direct me to where the bottles are

/obj/item/reagent_containers/glass/bottle/rogue/ its in roguejobs/alchemist if youre wondering where to find it

BlueMemesauce commented 1 month ago

it would be way cooler if you had to use the mortar and pestle and it was a chemical recipe rather than it being a crafting recipe

Hmeister-real commented 1 month ago

it would be way cooler if you had to use the mortar and pestle and it was a chemical recipe rather than it being a crafting recipe

dont know code

BlueMemesauce commented 1 month ago

i mean you added crafting recipes and chemical recipes are basically the same thing but with reagents instead of items

Hmeister-real commented 1 month ago

i mean you added crafting recipes and chemical recipes are basically the same thing but with reagents instead of items

i wouldnt know how to make the bbomb work as a reagent, and everything else uses the crafting menu anyway, so it would be weird to make it reagent based. also reagents wouldnt work for bulk 3x potions, since it would dupe reagents meaning infinite manna/health currently

ophaq commented 1 month ago

Make it so that it requires a mortar and pestle to craft if it isn't already like how you would need a table to sew a bag.

WindowTalents commented 1 month ago

I'm going to give my Towner Doctor level 2 in alchemy to go along with the stuff you have here, I gave him 1, but 2 seems more fitting.

I don't really see the point for 3x recipes when I can right click the craft button and just - remake more lol. But I am not complaining, I just dunno if it is fair to be able to mass produce SORTA the best items in the whole game LOL.

I LOVE preventing certain death with funny red drink, and you can even fit two in a pouch! Just to let you know, I usually loot 2 of those from the Terrorbog every round - and that is MORE than enough for a single player to have haha. Manna pots are situational, but EXTREMELY potent in those situations, since you can completely refill your "blue" meter when you would otherwise be basically done for in fights.

For basic alchemy implementation, this is perfect, absolutely NOTHING will go wrong from being able to craft the bombs!

TheManWithNoHands commented 1 month ago

Maybe make the crafting recipys a bit more expensive. Just berrys is a bit little. They are magical drugs after all. MAybe use the actual drugs we have already.

Hmeister-real commented 1 month ago

Maybe make the crafting recipys a bit more expensive. Just berrys is a bit little. They are magical drugs after all. MAybe use the actual drugs we have already.

thats why it's level 4 to craft them, so that Wizzos can sell potions others cannot make, for far cheaper than you can get at the merchants, but less reliably

Hmeister-real commented 1 month ago

i dont think merge conflicts are valid, from looking at them. it's literally just adding the alchemy skill to the two roles

Hmeister-real commented 1 month ago

I think this should be test mergd @ChungusGamer666 @Real-MAGNUM

WindowTalents commented 1 month ago

I am not a crafting expert. How much INT is required to no skill craft these? Keep this in mind basically.

Hmeister-real commented 1 month ago

I am not a crafting expert. How much INT is required to no skill craft these? Keep this in mind basically.

all of these are at least 3+, so more than 14 if you have no skill i believe to craft any actual potions. The bombs however just 12 to have a 2% chance. You could also hit a training dummy with a mortar and pestle or a bomb to train untill training gets fixed by Chungus...

WindowTalents commented 1 month ago

FOURTEEN IS VERY LOW LOL.

Orphans can make those... can it be made to be something SUPER hard to craft?

Health pots should be craftable, only, by the best lol.

TheManWithNoHands commented 1 month ago

thats why it's level 4 to craft them, so that Wizzos can sell potions others cannot make, for far cheaper than you can get at the merchants, but less reliably

As already stated, 4 isnt that high. And potions arent that expensive at the merchant. Costing about 21 mammons. But the fishes as ingredient is a fun idea. Maybe play with the rare versions of fish for recipys, could make the fisher more involved.

Hmeister-real commented 1 month ago

FOURTEEN IS VERY LOW LOL.

Orphans can make those... can it be made to be something SUPER hard to craft?

Health pots should be craftable, only, by the best lol.

sure, il make it 6

Hmeister-real commented 4 weeks ago

I've reverted my two new potions because A) i dont know how to code and they were almost entirely made with other peoples help B) They do not function correctly (dont remove stats after use, and dont decrease stats) C) someone more experienced can do a better job 100%

Hmeister-real commented 4 weeks ago

this is good for review, not gonna touch it again unless there are balance concerns

Hmeister-real commented 4 weeks ago

@ChungusGamer666 @ me on disc if you're gonna review

ChungusGamer666 commented 3 weeks ago

resolve conflicts and i merge

Hmeister-real commented 3 weeks ago

will fix later. FIguring out how to fix merg conflicts with VSC

Hmeister-real commented 3 weeks ago

Im just gonna remake this PR, wont take long. Later today GMT time

Hmeister-real commented 3 weeks ago

1308