search

Blackvein / Quests

Quests mod for Spigot
31 stars 35 forks source link

Possible fix to #329 #534

Closed Ry-DS closed 7 years ago

Ry-DS commented 7 years ago

In reference to #329 and post found here.. My spigot account is xBallisticBlazex. You can report if this fixed your issue there. I also performed some code cleanup.

Ry-DS commented 7 years ago

Currently working on something I found from the post you made on spigot

PikaMug commented 7 years ago

@SimplyBallistic Okay, I'll disregard this commit. Thanks!

Ry-DS commented 7 years ago

I believe that's it. @FlyingPikachu

Ry-DS commented 7 years ago

That was painful. Didn't get to run it through an ide so there will most likely be a mistake or two

Ry-DS commented 7 years ago

Please bring back the Class ColorUtil. The removal of this class ruined a lot of code on this pull request.

PikaMug commented 7 years ago

@SimplyBallistic The new changes look promising, I'll test it tomorrow (out of coffee).

Does your code depend on ColorUtil or is it a merge issue?

Ry-DS commented 7 years ago

Merge issue, I did a lot of code optimisation before you accepted the pull request by Greg. It happened right before I got the chance to pull hence the merge issue. I can try to fix it later without the need of that class. I am currently busy. @FlyingPikachu

PikaMug commented 7 years ago

@SimplyBallistic Using #215 I was able to recreate part of the bug using Quests 2.8.2-04 (does not include your fix), whereas a 'null' value was indeed placed in my player's data set. However, neither relogging nor restarting the server stopped the redo-delay from working. See my configuration here.

Shortly I'll take the same steps again, but with your changes. If a 'null' value is not created and everything works well as expected, I'll consider this fix satisfactory per our terms :)

PikaMug commented 7 years ago

@SimplyBallistic Unfortunately, a 'null' value was still created upon completing the quest. I tried it twice over, to be sure. See here.

Edit: I'm going to triple check and make sure this wasn't a goof on my part.

Edit2: Rather than copy/paste, I cloned SimplyBallistic/Quests, same result.

PikaMug commented 7 years ago

Resolved in #535