search

Blackvein / Quests

Quests mod for Spigot
31 stars 35 forks source link

Fix null bug in #329 #535

Closed 18PatZ closed 7 years ago

18PatZ commented 7 years ago

This should fix the appearance of the null entry in the completed-Quests section in the data files, assuming that the issue is caused by duplicate entries in the completedQuests list (when you complete a quest you've completed before). This issue is referenced in pull request #534.

My Spigot name is ShowbizLocket61.

PikaMug commented 7 years ago

@18PatZ Thanks for taking a look! Will try this out shortly. If no 'null' value is made and everything works OK, I'll consider this fix satisfactory per terms.

PikaMug commented 7 years ago

@18PatZ So, the 'null' value is gone, but has been replaced with a duplicate of the quest name.

18PatZ commented 7 years ago

@FlyingPikachu patched.

PikaMug commented 7 years ago

@18PatZ Testing now.

PikaMug commented 7 years ago

That did the trick! Player data looks as it should. I see now that the completedQuests list is already populated before it reaches the block you've been working on, at which point the duplicate entry was added, so I guess @Blackvein goofed or redo-able quests weren't expected to be in the completed-Quests player /data list (perhaps they're only supposed to be in completedRedoableQuests - only he would know). At any rate, I'm satisfied :)

Thanks for your help! Meet you back on Spigotmc for your payment.

SXRWahrheit commented 7 years ago

Would it be possible to show completed repeatable quests as repeatable, and enable particle effects if they are available? As it stands, players are confused - the lack of particle effects over NPCs and the "completed" status in the available quests (not just their quest log) makes it appear as though the quest is not repeatable.

https://www.spigotmc.org/threads/quests.47772/page-47#post-2503116

PikaMug commented 7 years ago

@SXRWahrheit My mistake, I should've been more clear on Spigot. This is no longer the official repo. Please create a new issue at the link below:

https://github.com/FlyingPikachu/Quests/issues

But yes, it's possible :)