search

Blackvein / Quests

Quests mod for Spigot
31 stars 35 forks source link

Module is closed too early #538

Closed BerndiVader closed 7 years ago

PikaMug commented 7 years ago

@BerndiVader Hey Wahrheit, thanks for your PR.

A user had reported this issue to me via Spigot PM yesterday morning. I applied an identical fix for him to try and was surprised that it didn't work; it seems we cannot close the jar even at the end of the block or it breaks the API.

Reverting to not closing the module at all solves this issue. I had initially done it because Eclipse complained about it being a resource leak, but frankly I doubt it'll hurt anything.

Gonna close this and push what I have, but thank you again!

PikaMug commented 7 years ago

Also, PRs should now be pushed to https://github.com/FlyingPikachu/Quests/pulls

SXRWahrheit commented 7 years ago

This is @BerndiVader's PR, not mine, just to be clear - he deserves all the credit!

PikaMug commented 7 years ago

@SXRWahrheit My mistake, I misread your Spigot post lol