search

BlackyHawky / Clock

Privacy-conscious open-source clock, based on AOSP Clock
Apache License 2.0
235 stars 13 forks source link

Play alarm sounds randomly. #98

Open ghost opened 1 month ago

ghost commented 1 month ago

Is your feature request related to a problem? Please describe. Play alarm sounds randomly.

Describe the solution you'd like Play alarm sounds randomly.

Use case I like that the alarm sounds change depending on the day.

Describe alternatives you've considered It might help you to implement this feature. github url https://github.com/mvarendorff/random-alarm https://github.com/tal3898/random-alarm

Additional context none.

Nilsu11 commented 1 month ago

@BlackyHawky for this feature to work we need to add storage permissions because a listener for ending songs/ringtones is non-existent in the ringtone class (same goes for any form of playing which requires changing sounds) . Is this reasonable as a tradeoff for this feature?

BlackyHawky commented 1 month ago

@Nilsu11

Is this reasonable as a tradeoff for this feature?

What do you mean? (Sorry to ask, I just want to make sure I understand your question.)

Nilsu11 commented 1 month ago

the tradeoff is the additional storage permission. So we get the new feature, but also a new permission (for reading music files I think, since the new player would require it). If I (or anyone) were to begin working on the feature, would this permission get in the way of the feature being merged?

BlackyHawky commented 1 month ago

I agree that someone could work on this, but I'd like to keep the current ringtone picker interface and not add any other dependencies.

Nilsu11 commented 1 week ago

@BlackyHawky this commit should implement this feature. note that I only included system alarms.