Blackymas / NSPanel_HA_Blueprint

This allows you to configure your complete NSPanel via Blueprint with UI and without changing anything in the code
1.45k stars 260 forks source link

Take default device icon if no icon is specified. #1127

Closed bkbartk closed 10 months ago

bkbartk commented 1 year ago

Now. When no icon is specified. For switches a switch icon is shown and for lights a light bulb. Is it possible to get de device icon specified in ha. I configured those so I always have the same icons in Lovelace. But unfortunately it doesn’t work on my Nspanel. I now have 2lightbulbs on my home screen.

edwardtfn commented 1 year ago

Could you please take a look at Developer Tools > States, pick some of those entities, can you see your selected icons on the attributes? I would expect that one to have preference over the default icon.

bkbartk commented 1 year ago

IMG_4707 I can see the icon. but at least on the homepage is shows a bulb. I know I can overrule. But I didn’t yet. I believe this is also the case for the overview pages. But to be honest I have to check when I get home.

bkbartk commented 1 year ago

I use v4. if this is different in v4.0.2. I need to update.

edwardtfn commented 1 year ago

No, v4.0.2 works with icons exactly the same as v4.0.

edwardtfn commented 10 months ago

The icon engine was rebuilt for v4.2 (still on dev) so I believe this will be solved with that release.

bkbartk commented 10 months ago

thnx, I was still planning on creating a fix for the single entity page but maybe now this isn't needed anymore.

edwardtfn commented 10 months ago

The new version is targeting ESPHome 2023.12.0, which may be released latter this week. It would be great if you can try v4.2dev when the new ESPHome is available and let me know if you still finding issues with icons. I will have some time next week and wanna use that to wrap up v4.2 and maybe we can release even before the end of the year.

bkbartk commented 10 months ago

I'm planning to update to v4.2dev for 2 weeks now and haven't found the time yet.

And with the upcoming holidays I won't be home much, So I will try to find some time but can't promise anything. I noticed the new default is esp-idf which is great, but I will check arduino as I use an external component which is not esp-idf compatible yet.

I see in the release notes of esphome you have done a lot of work improving the nextion component(nicely done). I assume all this new/improved stuff is used in v4.2, so using esphome 2023.11.x probably will fail.

edwardtfn commented 10 months ago

I'm planning to update to v4.2dev for 2 weeks now and haven't found the time yet. And with the upcoming holidays I won't be home much, So I will try to find some time but can't promise anything.

No rush. And wait a couple of days more until ESPHome 2023.12.0 is released (probably as that is required for v4.2.

I noticed the new default is esp-idf which is great, but I will check arduino as I use an external component which is not esp-idf compatible yet.

That is the default for new users, but if you have serial flashed with arduino you should stay there. Everything in this project is supposed to work (and tested) in both, so you should be good.

edwardtfn commented 10 months ago