search

Blackymas / NSPanel_HA_Blueprint

This allows you to configure your complete NSPanel via Blueprint with UI and without changing anything in the code
1.26k stars 234 forks source link

Allow to specify entity for HW button state status #1973

Closed lafriks closed 3 months ago

lafriks commented 3 months ago

Useful if need to use helper entity or other entity's status than one that is assigned to button.

Fixes #1959

edwardtfn commented 3 months ago

I'm afraid this will be very confusing to most users and will solve a very corner case for only a couple of users. 😩

lafriks commented 3 months ago

Would better description make it less confusing?

edwardtfn commented 3 months ago

Yeah, rephrase could help, but my point is more about defining this in a way we don't break it for everyone using the panel now. Like, using the entity assigned to the button if no entity is selected on this new input (and this should be in the description) if not there yet. I'm finishing something else here, then I come to your PR and will propose some changes on that direction. 😉

lafriks commented 3 months ago

I don't think it is breaking (at least I did try my best to make it so) as it will use state entity state only if it's provided, otherwise it will use controlled entities state

edwardtfn commented 3 months ago

These will probably take advantage if this PR:

lafriks commented 3 months ago

yes, sounds like similar use cases

edwardtfn commented 3 months ago

Thanks for your collaboration here. 🙂