search

BlafKing / sd-civitai-browser-plus

Extension to access CivitAI via WebUI: download, delete, scan for updates, list installed models, assign tags, and boost downloads with multi-threading.
GNU Affero General Public License v3.0
309 stars 53 forks source link

[Bug]: Model Preview Update Overwrites all Models Despite Unchecking the "Overwrite" Box #123

Closed SchofieldPriest closed 10 months ago

SchofieldPriest commented 10 months ago

Describe the bug.

In the "Update Models" portion, after unchecking the "Overwrite any existing previews, tags or descriptions." box and selecting the "Scan for Lora" option, CivitAI+ will still proceed to update the preview images of all of my Loras rather than only the ones that don't have a model preview. This leads to redundant downloads and a lot of extra time by the program spent doing so.

Steps to reproduce the problem.

  1. Go to Update Models
  2. Check LORA, then uncheck "Overwrite any existing previews, tags or descriptions."
  3. Press "Update Model Previews"
  4. After sending all API requests, the extension will proceed to download a new preview for every model, rather than just the ones that have no preview.

Expected behavior

After sending all API requests, the extension should only download previews for models that don't currently have one.

System info

Console logs

cmd log continues as normal, but saves a preview image for every model

Additional information

No response

BlafKing commented 10 months ago

Thanks for letting me know!

This was caused by a silly oversight, I've made a quick hotfix for it that should fix the issue! :)

SchofieldPriest commented 10 months ago

Thank you @BlafKing ! How can I install this hotfix? I reinstalled the extension, but it doesn't seem like the fix was implemented that way.

BlafKing commented 10 months ago

Thank you @BlafKing ! How can I install this hotfix? I reinstalled the extension, but it doesn't seem like the fix was implemented that way.

Did you install the latest commit from this github or the latest from CivitAI? (Since I haven't updated the version on CivitAI yet, I will include this hotfix there in the next update.)

You can have a look here to see how to install the latest version from github, I recommend using the automatic installation method :)