BlafKing / sd-civitai-browser-plus

Extension to access CivitAI via WebUI: download, delete, scan for updates, list installed models, assign tags, and boost downloads with multi-threading.
GNU Affero General Public License v3.0
309 stars 53 forks source link

[Bug]: muliple results with same model name not working #170

Closed Git-Maniac closed 8 months ago

Git-Maniac commented 8 months ago

Describe the bug.

if you search a model and get more than one results with the same model name, you can only download the 1st one. All other results download the 1st one again

Steps to reproduce the problem.

  1. Search model name like "chastain SDXL"
  2. select the 1st result, you can download it
  3. select the 2nd result, it download the 1st one again

Expected behavior

Download the files from the selected model

System info

Console logs

No error just wrong files downloaded

Additional information

As workaoround you can search by the user name, therefore you never have results with same model name

BlafKing commented 8 months ago

Thanks for reporting!

The model selection was done by model name, instead of something which is always unique like a model ID.

Was way more work than I anticipated, since a lot of the code was built on detecting models by their name, but I have now switched to selecting models by their ID instead in (v3.2.5)!

This bug should now be fixed so I'll close this issue! :)

Git-Maniac commented 8 months ago

Amazing work, thank you lots. Still some small bugs left. If models have the same name: