search

BlairLeduc / touch-bar-display

VSCode Touch Bar Display Commands Extension
MIT License
14 stars 9 forks source link

Broken in 1.31.0? #2

Closed alistairholt closed 5 years ago

alistairholt commented 5 years ago

I've gotten into the habit of using this extension all the time but after updating to VSCode 1.31.0 today it's no longer working 😢

shpontex commented 5 years ago

same here, mac os mojave 10.14.2

gaomeng1900 commented 5 years ago

Seems not working for 1.31.0

shpontex commented 5 years ago

i tried many other touch bar extensions but no one worked it seems like a general problem

alistairholt commented 5 years ago

Seems to be an issue for other extensions too: https://github.com/NascHQ/nasc-vscode-mac-touchbar/issues/25.

alistairholt commented 5 years ago

Is it due to an extra button being added to the default Touch Bar leaving less space, and therefore hiding, touch-bar-display buttons?

shpontex commented 5 years ago

yes may be , but i dont know the utility of the new button it does the same thing as the old one

alistairholt commented 5 years ago

I'd ideally like to drop the default buttons entirely and fully customise the Touch Bar but that doesn't seem to be possible 🤔 .

shpontex commented 5 years ago

yeh , you can do "keyboard.touchbar.enabled": false, but all the buttons will be hidden

alistairholt commented 5 years ago

Yes, frustrating. I do miss the full control I had when using Atom.

shpontex commented 5 years ago

i added a new issue on vscode github page as well will see if they can do something... https://github.com/Microsoft/vscode/issues/68214

shpontex commented 5 years ago

@alistairholt i modified the code and removed two buttons from the touch bar but i doesn't work, so its not a button space problem i think i will use a previous version of vscode until somebody fix this problem

BlairLeduc commented 5 years ago

I took a look last night and came to the same conclusion. Thank you everyone for validating this and opening an issue to vscode.

BlairLeduc commented 5 years ago

If it is a problem with the amount of space, which buttons should we drop?

alistairholt commented 5 years ago

My personal experience is that I very rarely touch the search icon – I'm usually accessing this via a keyboard shortcut – cmd+f or cmd+shift+f. I would guess that the extensions icon isn't used that frequently.

bpasero commented 5 years ago

See this issue as explanation: https://github.com/electron/electron/issues/16473

shpontex commented 5 years ago

@BlairLeduc For me it’s the debug button that I don’t use often

alistairholt commented 5 years ago

We pushed a fix on our end by changing the icon sizes. Seems fine now.

https://github.com/electron/electron/issues/16473#issuecomment-457283587

Perhaps this would work here too?

bpasero commented 5 years ago

I cannot reproduce this btw, however I am using the touchbar simulator (https://sindresorhus.com/touch-bar-simulator/) and the buttons showup just fine.

The change with Electron 3 that we had to work on was a change in how large icons would appear in the touchbar. They showed up much larger causing the touchbar to drop all the debug items at the end because space got little. It is possible that extensions have to update their icon sizes to account for that.

bpasero commented 5 years ago

One thing that might help is to disable "Show control strip" from:

image

BlairLeduc commented 5 years ago

Unfortunately, VSCode controls the width of the buttons, or perhaps this comes from Electron. Whichever, this is completely out of the extensions control.

Reyshawn commented 5 years ago

Same problem.

shpontex commented 5 years ago

i tried what @bpasero said and disabled "Show control strip" and all the button showed but as you can see in the image below the buttons display has changed tuchbar_5

i tried to remove the buttons one by one and i end up by having 2 buttons work touchbar_2

so i looked inside the vscode files and the touchbar icons has 60px size, so i changed the icons from 100px top 60px and now i got a better buttons display but with the new button on the left i could only get 4 buttons to show, so i removed the debug button. touchbar_after

i made a pull request with this update if it can help

bpasero commented 5 years ago

Changing the size of the icon is the right fix for this, VSCode did the same 👍

BlairLeduc commented 5 years ago

@shpontex Thanks! I merged the pull request and I will update the store today.

BlairLeduc commented 5 years ago

The updated extension is up in the Marketplace. Could someone let me know if the changes work for them?

alistairholt commented 5 years ago

@BlairLeduc I'm running 1.2.1 from the marketplace but I'm not seeing the any buttons other than the VSCode defaults. 🤔

alistairholt commented 5 years ago

@BlairLeduc Looks like I spoke too soon. It's now working! 👍