search

Blake2912 / Vahini-2.0

A Self-Driving Auto-irrigation Electric Vehicle
2 stars 1 forks source link

Geocode Trees Stretch Implementation #32

Closed amartyanambiar closed 1 year ago

amartyanambiar commented 1 year ago

Ideal Solution for #21 This PR solves the problem of geocoding trees by using the Stretch-wise Implementation. In the upcoming comments, you shall find detailed explanation for changes in the files.

This PR is to be merged into geocode-trees After merge, within geocode-trees, work upon the generalisation of the test cases according to the UI selection shall be performed and incorporating validation steps too.

Testing :

run app.py run unpickle.py with your desired nodes to check whether the shortest route is right.(path is correctly implemented) Also check graph.png

amartyanambiar commented 1 year ago 
['cmrit_entrance', 'teacher_parking', 'volley_ball_court', 'basic_science', 'ganesha_statue', 'hostel_turn', 't-1', 't-2', 't-3', 't-4', 't-5', 't-6']
    raise nx.NetworkXNoPath(f"No path between {source} and {target}.")
networkx.exception.NetworkXNoPath: No path between t-1 and volley_ball_court.

I m getting this error when I run the unpickle.py file @amartyanambiar can you look into what's the issue?

I m not sure if I am missing something I followed the above mentioned instructions

I very clearly mentioned in the above comments that I have given test cases for only two stretches. So, test it using the nodes present in them. Check here --> https://github.com/Blake2912/Vahini-2.0/pull/32#discussion_r1155531383

U can add other test cases similarly as I did. and it should work fine ideally.

Blake2912 commented 1 year ago

I haven't changed any node here I just ran it from the terminal that's it... so implicitly wouldn't an ideal case get fired up?

amartyanambiar commented 1 year ago

I haven't changed any node here I just ran it from the terminal that's it... so implicitly wouldn't an ideal case get fired up?

Because I didn't push my unpickle.py.(futile push, nodes keep changing for test cases) Change nodes in requested shortest_path statement.