BlakeBr0 / Cucumber

A library of shared code and functionality used by my mods.
https://blakesmods.com/cucumber
MIT License
23 stars 15 forks source link

Reusable Items have one too few uses. #10

Closed Darkere closed 4 years ago

Darkere commented 4 years ago

https://github.com/BlakeBr0/Cucumber/blob/273c104a047c7e79e4290a030e14544c99b2eab3/src/main/java/com/blakebr0/cucumber/item/ReusableItem.java#L57

You are returning ItemStack.EMPTY if the damage equals maximum damage. This means the information doesn't match what's on the tooltip and also breaks autocrafting calculation.

Example: Mystical agriculture Infusion crystal with damage at 998 shows it has 2 uses left but can only be used once.