search

BlakeBr0 / MoreBuckets

Adds some more buckets to Minecraft.
https://blakesmods.com/more-buckets
MIT License
5 stars 3 forks source link

Random single player to server disconnect issue only happens when "MoreBuckets" is installed. Removing Fixes the issue #12

Closed Zelioth closed 3 months ago

Zelioth commented 5 months ago

Describe the bug I have been having an issue recently where when connecting to a server with the EXACT same mods as the client causes an error and disconnects the client. After days of removing, adding, and testing in a controlled environment I found that the mod is More Buckets. This may be a compatibility issue with another mod but I couldn't find another mod that caused the issue when More Buckets was included.

To Reproduce Forge, 1.20.1, Dedicated Server, Single Player. Connecting to each other this error occurs.

Versions (please complete the following information):

Zelioth commented 5 months ago

image

Forgot to include screenshot

BlakeBr0 commented 5 months ago

Does this issue still persist if you set enableRecipeFixer to false in the config?

Zelioth commented 5 months ago

I am not sure. I will test and find out. Now I am getting an error on startup for Iron Jet packs -_- crash-2024-06-04_01.32.43-fml.txt

Shotguun29 commented 4 months ago

Having the same issue with ver MoreBuckets-1.20.1-4.0.2.jar and 4.0.1 Running ver 4.0.0 works

Agentx49 commented 4 months ago

same issue here

BlakeBr0 commented 3 months ago

Do you guys have enableRecipeFixer set to true? I'm guessing there's some sort of incompatibility with another mod, but I can't really do anything about it without any error logs.

If the issue only started in version 4.0.1, then the only thing I can think of is that there is some weirdness with ingredients that contain modded milk buckets. If someone could test this potential fix that would be appreciated:

https://drive.google.com/file/d/1d0XRd1gfK0lT5PpsFlMXN6yLIL3Xt_b7/view?usp=sharing

Zelioth commented 3 months ago

GIve me a little bit and I will test. setting up the server environment now

Zelioth commented 3 months ago

image debug.log latest.log

Looks like its not fixed on the latest versions of all mods, forge, and that file you shared.

Zelioth commented 3 months ago

Testing the enableRecipeFixer set to true now.

changed it to false in the config file for the server. Looks like it allows connection. So whatever the recipe fixer is doing is breaking things.

BlakeBr0 commented 3 months ago

These recipe/ingredient serialization errors are the worst because the actual error doesn't get logged from what I can tell, so I can't see where things are going wrong. It must be something to do with certain ingredient types or something another mod is doing that I'm not accounting for.

Here's another potential fix:

https://drive.google.com/file/d/14gI9OyGEF-Jqi83fyIoVwD4X2-1bOg8z/view?usp=sharing

Someone above said that version 4.0.0 didn't have this issue. If this fix doesn't work can you also confirm if that's the case?

Zelioth commented 3 months ago

Looks like whatever you changed allowed for the client to connect to the server without any issues. Honestly I haven't tested it but Thermal Expansion by TeamCofH has caused a bunch of issues with other mods so I wouldn't be surprised.

BlakeBr0 commented 3 months ago

Sweet, I'll release the fix then. Hopefully it fixes all instances of this issue.