BlakeBr0 / MysticalCustomization

Allows modpack creators to add new content and modify existing content in Mystical Agriculture.
https://blakesmods.com/mystical-customization
MIT License
6 stars 6 forks source link

Custom texture doesn't create models files #41

Closed MLDEG closed 8 months ago

MLDEG commented 11 months ago

Describe the bug Creating a new seed with custom textures doesn't create the models json to display the textures, while applying a color to the base texture works.

To Reproduce In the json file "mysticalcustomization/crops" remove the "color" line and add the "seeds" line to "textures" and put the path of the custom textures (e.g. "kubejs:item/aquite_essence")

Expected behavior Show textures ingame with custom textures applied

Screenshots / Scripts / Logs Logs: https://pastebin.com/xq7R2ABc

2023-09-14_11 21 42

This is my json file for an Aquite seed https://pastebin.com/ZDRDr0pp

Versions (please complete the following information):

Thank you for your work !

BlakeBr0 commented 11 months ago

I somewhat unintentionally removed the automatic model generation in 1.20. I'll see if I can re-add that in some form if it doesn't cause issues.

In the mean time you could probably add those files to your resource pack manually. I'm not sure how it would work using kubejs. Theoretically, you could add the models to a resource pack in the mysticalagriculture namespace corresponding to the generated block/items in game and they should load like normal.

MLDEG commented 11 months ago

I was hesitant to add them manually in the first place, so I'm going to add them while waiting for an update that will potentially fix the problem.

Thank you =)

BlakeBr0 commented 10 months ago

I looked into re-adding this earlier and figured out why I removed this functionality in the first place. In 1.19.3 Mojang changed a ton of the internals for model loading which made it so my method of dynamically generating them didn't work anymore.

I think what I'll do is add documentation for this use case since doing it dynamically is significantly more difficult now.

BlakeBr0 commented 8 months ago

I added a section to the docs with examples: https://blakesmods.com/docs/mysticalcustomization/adding-crops#custom-models