BlakeBr0 / MysticalCustomization

Allows modpack creators to add new content and modify existing content in Mystical Agriculture.
https://blakesmods.com/mystical-customization
MIT License
6 stars 6 forks source link

Crops always need "crux:" parameter, only one crop was created #9

Closed hodo1962 closed 3 years ago

hodo1962 commented 3 years ago

Describe the bug I've written two .json files like described in the wiki. The first crop was created, but only when the "crux:" parameter was available in the file. Without this parameter nothing happened. The crop from the second file was never created

Crop file 1, c1.json { "name": "C1", "type": "resource", "tier": "mysticalagriculture:2", "ingredient": { "item": "mekanism:fluorite_gem" }, "color": "f8f8ff", "textures": { "flower": "mysticalagriculture:block/flower_dust", "essence": "mysticalagriculture:item/essence_gem" }, "crux": "minecraft:cobblestone", }

Crop file 2, c2.json: { "name": "C2", "type": "resource", "tier": "mysticalagriculture:4", "ingredient": { "item": "minecraft:gold_ingot" }, "color": "eb7a34", "textures": { "flower": "mysticalagriculture:block/flower_dust", "essence": "mysticalagriculture:item/essence_dust" }, "crux": "minecraft:cobblestone", } To Reproduce I've tried both files, with and without the "crux:" parameter.

Expected behavior I think it normally should create two different crops.

Screenshots / Scripts / Logs Found the following lines in the log:

[16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: mysticalagriculture:blockstates/c1_crop.json: java.io.FileNotFoundException: mysticalagriculture:blockstates/c1_crop.json

[16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=5' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=4' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=7' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=6' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=1' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=0' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=3' [16:32:14] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Exception loading blockstate definition: 'mysticalagriculture:blockstates/c1_crop.json' missing model for variant: 'mysticalagriculture:c1_crop#age=2'

[16:32:15] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Unable to load model: 'mysticalagriculture:c1_essence#inventory' referenced from: mysticalagriculture:c1_essence#inventory: java.io.FileNotFoundException: mysticalagriculture:models/item/c1_essence.json

[16:32:15] [Worker-Main-10/WARN] [minecraft/ModelBakery]: Unable to load model: 'mysticalagriculture:c1_seeds#inventory' referenced from: mysticalagriculture:c1_seeds#inventory: java.io.FileNotFoundException: mysticalagriculture:models/item/c1_seeds.json

[16:33:19] [Render thread/WARN] [minecraft/ClientRecipeBook]: Unknown recipe category: mysticalagriculture:reprocessor/mysticalagriculture:c1_seeds_reprocessor

[16:33:19] [Render thread/WARN] [minecraft/ClientRecipeBook]: Unknown recipe category: mysticalagriculture:infusion/mysticalagriculture:c1_seeds_infusion

The c2 - crop wasn't mentioned in the log.

Versions (please complete the following information):

hodo1962 commented 3 years ago

I've found the mistake. It's the last comma in the script. Without the crux parameter there should be no comma before the final brace. I've tested this a lot and camé to the conclusion that the bug was between my ears :D This can be closed!

BlakeBr0 commented 3 years ago

Yeah, JSON can be annoying when it comes to commas.