search

BlakeBr0 / PickleTweaks

A bunch of features and tweaks that I don't think need their own mods.
https://blakesmods.com/pickle-tweaks
MIT License
5 stars 8 forks source link

Don't drop items before giving other mods an opportunity to change drops #45

Closed sam-kirby closed 4 years ago

sam-kirby commented 4 years ago

Creating item entities does before firing HarvestDropEvent does not allow other mods the opportunity to respond to the proposed drop array, resulting in bugs such as #33.

This adjusts the sequence so that event is fired before drops are spawned, meaning mods are free to change which drops will be spawned.

sam-kirby commented 4 years ago

Worth noting that the same issue is present in the 1.14 branch.

sam-kirby commented 4 years ago

Is there any chance this could be incorporated into the master (1.12) branch as well?

BlakeBr0 commented 4 years ago

I have no plans to work on 1.12 any longer.