search

BlakeBr0 / PickleTweaks

A bunch of features and tweaks that I don't think need their own mods.
https://blakesmods.com/pickle-tweaks
MIT License
5 stars 8 forks source link

Calculated repair #55

Closed bolte-io closed 3 years ago

bolte-io commented 4 years ago

Hey,

More of a feature suggestion. When I try and repair an item, it only seems to count 1 item for a slight repair. It would be better if I put more than 1 ingredient in with the tool for it to repair to the amount of ingredients I place.

i.e; If my tool is 75% damaged and my repair setting is 4, then I should be able to put 3x ingredient in with the tool and have it be fully repaired when I take it out of the crafting grid.

At the moment to do a full repair I have to put 1x ingredient in, take the tool and put it back in the grid again to repair even more. QOL issue really I know.

BlakeBr0 commented 4 years ago

This is already how it works.

bolte-io commented 4 years ago

Then in the below screenshot, the result should be a fully repaired pickaxe with 64 gold in the crafting grid, or am I muss-understanding the feature?

Repair

BlakeBr0 commented 4 years ago

You use multiple slots.

bolte-io commented 4 years ago

Like this?

Repair

BlakeBr0 commented 4 years ago

Yeah like that. What version are you using? I don't remember ever seeing this feature not work before.

bolte-io commented 4 years ago

Now I know it's potentially a bug rather than a missing feature, I will investigate further by stripping the pack down to minimal and retesting, however I don't really have any content mods, just performance enhancing mods and JEI.

I am using 1.12.2, latest Forge available 14.23.5.2854. I reduced the setup to just your mod and cucumber, and it now works as expected when putting multiple ingots surrounding the pickaxe.

Just a question, but why can you not have it calculate with a number of ingots on the same slot? I have no idea which mod would be interfering with this process tbh. I have no content mods, so now I have to build this back up and re-test until I find the culprit.

Now

bolte-io commented 4 years ago

I have found the culprit, it is Fast Workbench, soon as that mod is introduced it causes this issue. FastWorkbench-1.7.3

EDIT: It still does not work where the repair is multiplied by the ingredient placed in the same slot, however, if that was how it should work.

BlakeBr0 commented 4 years ago

That's good to know. I never would've figured that out myself since I always just used the inventory crafting grid for repairs. The reason I'm not going to make it take multiple items from one slot is that it's not consistent with the rest of the recipes in the game and because of that I don't think it would be as intuitive.

bolte-io commented 4 years ago

I have seen it work that way with other mods, but from my point of view, it's actually more convenient to right click and deposit them one by one in place on the grid, but it's not so difficult just to right click drag out a shape. Just is my preference, maybe just have the option and toggle it in the config.

What do you plan to do about the incompatibility with Fast Workbench? Reason I ask is there are a lot of dependents on Fast Workbench, so a lot of modpacks use it.

BlakeBr0 commented 3 years ago

I don't plan to do anything as weird incompatibilities like this are bound to happen when cutting corners for performance.