BlakeBr0 / PickleTweaks

A bunch of features and tweaks that I don't think need their own mods.
https://blakesmods.com/pickle-tweaks
MIT License
5 stars 7 forks source link

Tool Properties Reported Incorrectly #71

Closed SilentChaos512 closed 3 years ago

SilentChaos512 commented 3 years ago

Describe the bug

The harvest level and speed reported for some tools (such as those from Silent Gear) is incorrect.

To Reproduce

Examine any Silent Gear tool. I imagine Tinkers Construct tools would produce a similar issue.

Expected behavior

Harvest level and speed should be reported correctly, using ItemStack-sensitive methods, and ignoring the tool material.

I have not had a chance to check your code, but I imagine checking the tool material or calling the wrong methods is the cause. In the case of Silent Gear, all items use a dummy material with harvest level 3 and harvest speed 8, which is reported for all Silent Gear tools. The tooltips added by Silent Gear still display the correct values.

Screenshots / Scripts / Logs

Relevant issue here: https://github.com/SilentChaos512/Silent-Gear/issues/361

Versions (please complete the following information):

(copied from 361)